Wrong return type on create_timer()

[Rasmus-S-Kristensen]

🐛 Describe the bug
Type hint for return value of create_timer() is TaskBase, but that does not contain the cancel() function. Returning TimerTask seems more appropiate.

Edit: See comment below on why TimerTask might not be a viable type anyway

Current source:

azure-functions-durable-python/azure/durable_functions/models/DurableOrchestrationContext.py

Line 601 in 4ab004b

def create_timer(self, fire_at: datetime.datetime) -> TaskBase:

Example code:

    expiration = context.current_utc_datetime + timedelta(seconds=20)
    timeout_task = context.create_timer(expiration)
    timeout_task.cancel()  # <-- Pylance shows error: "Cannot access attribute "cancel" for class "TaskBase""

🤔 Expected behavior
You should be able to call cancel()without linter/type checker errors.

☕ Steps to reproduce
See above

[Rasmus-S-Kristensen]

I have just learned of the presence of LongTimerTask, which probably makes the situation a bit more complex, as it is also a timer, but the inheritance structure is different:

LongTimerTask -> WhenAllTask -> CompoundTask -> TaskBase
TimerTask -> AtomicTask -> TaskBase

Given the current inheritance, the current implementing is not wrong. I would however argue that it would be nice to have a different type returned, that contained the cancel functionality.

[andystaples]

Possible duplicate of #330 but keeping both as that was the original issue and this one covers LongTimerTask.
Note: azure-functions-durable v2 is developed as strictly typed and covers this and many other type-safety issues. Not closing this issue as superseded yet, though