Skip to content

Inconsistent naming get_json() in EventGridEvent and EventGridOutputEvent #159

Description

@pjung-bosch

Both mentioned classes have methods called get_json which return the classes __data field. This seems odd for two reasons:

  1. They don't actually return JSON but a dict (if the typing hints in __init__ are correct). In any case this is a major source of confusion.
  2. All other getters are implemented as properties. (So why not just do the same here?)

def get_json(self) -> typing.Any:
return self.__data

def get_json(self) -> typing.Any:
return self.__data

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions