Skip to content

NSUrlConnection wrapper returns "Bad Request" NSData instead of NSError #12

Description

@dodikk

Steps :
Attempt to download a file from the URL that returns "HTTP 400" error.

Actual result : "Bad request" string is returned in plain text
Expected result : A valid JHttpError is returned.


JFFAsyncOperation genericDataURLResponseLoader(JFFURLConnectionParams *params)
{
   return privateGenericDataURLResponseLoader(params, nil);
}

dataURLResponseLoader() implementation is missing the downloadErrorFlagResponseAnalyzer() predicate (nil is used as a stub). Adding the mentioned predicate solves the issue but some backward compatibility checks (code review) are required.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions