Description
When BetterMap is installed alongside HyperFactions, POI markers (Kweebec camps, villages, etc.) appear on the world map despite HyperFactions normally hiding them. Without BetterMap, these POIs are hidden because our generatePointsOfInterest() returns an empty map.
Steps to Reproduce
- Install HyperFactions without BetterMap
- Open world map — no POI markers visible (expected)
- Install BetterMap (v1.3.3+) alongside HyperFactions
- Open world map — pink tent POI markers now visible in explored areas
Expected Behavior
POI visibility should be consistent whether BetterMap is installed or not. Ideally, faction mods should be able to selectively control POI visibility (e.g., hide POIs in enemy territory, show in friendly territory).
Root Cause
BetterMap wraps the native POIMarkerProvider with its own PoiPrivacyProvider, which discovers and caches POIs independently from HyperFactions' generator. By the time our delayed registration replaces the generator (which returns empty POIs), BetterMap has already captured the original POI data.
Current Workaround
Set hideAllPoiOnMap: true in BetterMap's config.json. This is all-or-nothing — no per-faction filtering.
Proper Fix
Requires a MapMarkerFilter API from BetterMap that allows external mods to filter POI/warp/spawn markers based on custom logic (e.g., faction territory ownership). This has been proposed upstream:
Proposed API summary
We've proposed three interfaces to the BetterMap team:
-
PlayerVisibilityFilter — A @FunctionalInterface that external mods register on PlayerRadarManager to control per-viewer/per-target radar visibility. Multiple filters stack with AND logic. This would replace the HiddenPlayersManager workaround we currently use.
-
ExplorationSharingProvider — Allows faction/team/party mods to share explored chunks between members, so faction territory appears explored for all members.
-
MapMarkerFilter — Allows external mods to filter non-player markers (POIs, warps, spawn, death) based on custom logic like faction territory ownership. This is what would fix this specific issue.
Related
Description
When BetterMap is installed alongside HyperFactions, POI markers (Kweebec camps, villages, etc.) appear on the world map despite HyperFactions normally hiding them. Without BetterMap, these POIs are hidden because our
generatePointsOfInterest()returns an empty map.Steps to Reproduce
Expected Behavior
POI visibility should be consistent whether BetterMap is installed or not. Ideally, faction mods should be able to selectively control POI visibility (e.g., hide POIs in enemy territory, show in friendly territory).
Root Cause
BetterMap wraps the native
POIMarkerProviderwith its ownPoiPrivacyProvider, which discovers and caches POIs independently from HyperFactions' generator. By the time our delayed registration replaces the generator (which returns empty POIs), BetterMap has already captured the original POI data.Current Workaround
Set
hideAllPoiOnMap: truein BetterMap'sconfig.json. This is all-or-nothing — no per-faction filtering.Proper Fix
Requires a
MapMarkerFilterAPI from BetterMap that allows external mods to filter POI/warp/spawn markers based on custom logic (e.g., faction territory ownership). This has been proposed upstream:Proposed API summary
We've proposed three interfaces to the BetterMap team:
PlayerVisibilityFilter— A@FunctionalInterfacethat external mods register onPlayerRadarManagerto control per-viewer/per-target radar visibility. Multiple filters stack with AND logic. This would replace theHiddenPlayersManagerworkaround we currently use.ExplorationSharingProvider— Allows faction/team/party mods to share explored chunks between members, so faction territory appears explored for all members.MapMarkerFilter— Allows external mods to filter non-player markers (POIs, warps, spawn, death) based on custom logic like faction territory ownership. This is what would fix this specific issue.Related