Skip to content

Zorro Cipher: zorro_InvMixColumns disregards offset parameter #16

Description

@MiragePV

Seems like zorro_InvMixColumns() function should account for offset parameter in the similar fashion as zorro_MixColumn() does.

temp[(short)(j + offset_cpy)] = internBuffer[(short)((i * 4) + j)];
should be:
temp[(short)(j + offset_cpy)] = internBuffer[(short)((i * 4) + j + offset)];
and similarly
internBuffer[(short)((i * 4) + j)] = temp[(short)(j + offset_cpy)];
should be:
internBuffer[(short)((i * 4) + j + offset)] = temp[(short)(j + offset_cpy)];

Otherwise short offset parameter has no meaning and actually may cause erroneous calculation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions