From 3d7744cf84e88e2ae7669965d8b4572312408fb9 Mon Sep 17 00:00:00 2001 From: "kiloconnect[bot]" <240665456+kiloconnect[bot]@users.noreply.github.com> Date: Fri, 11 Sep 2026 07:39:10 +0000 Subject: [PATCH] (janitor/test-prune): prune zod framework-behavior test in cloud-agent-sdk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the "reproduces the old interleaved enum rejecting CLI catalogs" test in remote-model-catalog.test.ts. It constructs a throwaway zod union entirely inside the test and asserts zod's built-in enum rejection, so it never executes any repository-owned production code and cannot fail on a production regression — only a zod behavior change or a lockstep edit to the test's own literals would break it. The contract this test gestures at is already covered by the adjacent "accepts CLI interleaved field names the picker does not use" test, which exercises the real remoteModelCatalogV1Schema with each of the four CLI field names. --- .../cloud-agent-sdk/src/remote-model-catalog.test.ts | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/packages/cloud-agent-sdk/src/remote-model-catalog.test.ts b/packages/cloud-agent-sdk/src/remote-model-catalog.test.ts index 9e25fbef2f..1f0ac01ee0 100644 --- a/packages/cloud-agent-sdk/src/remote-model-catalog.test.ts +++ b/packages/cloud-agent-sdk/src/remote-model-catalog.test.ts @@ -1,5 +1,3 @@ -import { z } from 'zod'; - import { REMOTE_MODEL_CATALOG_MAX_SERIALIZED_BYTES, REMOTE_MODEL_IDENTITY_MAX_LENGTH, @@ -151,16 +149,6 @@ function createUtf8OversizedCatalog() { } describe('remoteModelCatalogV1Schema', () => { - it('reproduces the old interleaved enum rejecting CLI catalogs', () => { - const oldInterleaved = z.union([ - z.boolean(), - z.object({ field: z.enum(['reasoning_content', 'reasoning_details']) }).strict(), - ]); - - expect(oldInterleaved.safeParse({ field: 'reasoning_text' }).success).toBe(false); - expect(oldInterleaved.safeParse({ field: 'reasoning' }).success).toBe(false); - }); - it('accepts CLI interleaved field names the picker does not use', () => { const fields = ['reasoning', 'reasoning_content', 'reasoning_details', 'reasoning_text'];