diff --git a/api/src/org/labkey/api/exp/api/ExperimentService.java b/api/src/org/labkey/api/exp/api/ExperimentService.java index fd0b9fce06f..259e36f75e6 100644 --- a/api/src/org/labkey/api/exp/api/ExperimentService.java +++ b/api/src/org/labkey/api/exp/api/ExperimentService.java @@ -82,7 +82,6 @@ import org.labkey.api.reader.TabLoader; import org.labkey.api.security.User; import org.labkey.api.services.ServiceRegistry; -import org.labkey.api.util.IntegerUtils; import org.labkey.api.util.Pair; import org.labkey.api.util.StringUtilsLabKey; import org.labkey.api.view.HttpView; @@ -1384,16 +1383,4 @@ public XarImportOptions setStrictValidateExistingSampleType(boolean strictValida return this; } } - - @Deprecated // Use IntegerUtils.asLong() instead - static Long asLong(Object o) - { - return IntegerUtils.asLong(o); - } - - @Deprecated // Use IntegerUtils.asInteger() instead - static Integer asInteger(Object o) - { - return IntegerUtils.asInteger(o); - } } diff --git a/api/src/org/labkey/api/query/UserIdRenderer.java b/api/src/org/labkey/api/query/UserIdRenderer.java index f15cc015230..90320f759ff 100644 --- a/api/src/org/labkey/api/query/UserIdRenderer.java +++ b/api/src/org/labkey/api/query/UserIdRenderer.java @@ -78,13 +78,13 @@ public String renderURL(RenderContext ctx) return null; boolean isDeletedUser = UserManager.getUser(displayedUserId) == null; - if (!isDeletedUser && displayedUserId != null) + if (!isDeletedUser) { - ActionURL url = UserManager.getUserDetailsURL(ctx.getContainer(), loggedInUser, displayedUserId); - if (url != null) - { - return url.toString(); - } + ActionURL url = UserManager.getUserDetailsURL(ctx.getContainer(), loggedInUser, displayedUserId); + if (url != null) + { + return url.toString(); + } } return null; diff --git a/api/src/org/labkey/api/search/NoopSearchService.java b/api/src/org/labkey/api/search/NoopSearchService.java index 56be54eb815..006cbef00cb 100644 --- a/api/src/org/labkey/api/search/NoopSearchService.java +++ b/api/src/org/labkey/api/search/NoopSearchService.java @@ -365,6 +365,13 @@ public void pauseCrawler() { } + @Override + public boolean isSearchIconVisible() + { + // No persisted setting to consult, so don't be the reason the header hides the icon + return true; + } + @Override public @Nullable Throwable getConfigurationError() { diff --git a/api/src/org/labkey/api/search/SearchService.java b/api/src/org/labkey/api/search/SearchService.java index 0dd6ae0ada7..874b22cbe3f 100644 --- a/api/src/org/labkey/api/search/SearchService.java +++ b/api/src/org/labkey/api/search/SearchService.java @@ -442,6 +442,9 @@ public String normalizeHref(Path contextPath, Container c) void resetIndex(); void startCrawler(); void pauseCrawler(); + + /** @return should the search icon be shown in the page header; controlled from the Full-Text Search admin page */ + boolean isSearchIconVisible(); void updateIndex(String reason); void refreshNow(); diff --git a/core/src/org/labkey/core/view/template/bootstrap/header.jsp b/core/src/org/labkey/core/view/template/bootstrap/header.jsp index 5369a16f4cf..c43d52c28f5 100644 --- a/core/src/org/labkey/core/view/template/bootstrap/header.jsp +++ b/core/src/org/labkey/core/view/template/bootstrap/header.jsp @@ -19,6 +19,7 @@ <%@ page import="org.labkey.api.data.Container" %> <%@ page import="org.labkey.api.module.ModuleLoader" %> <%@ page import="org.labkey.api.portal.ProjectUrls" %> +<%@ page import="org.labkey.api.search.SearchService" %> <%@ page import="org.labkey.api.search.SearchUrls" %> <%@ page import="org.labkey.api.search.SearchUtils" %> <%@ page import="org.labkey.api.security.AuthenticationManager" %> @@ -83,7 +84,6 @@ LookAndFeelProperties laf = LookAndFeelProperties.getInstance(c); ModuleLoader moduleLoader = ModuleLoader.getInstance(); boolean isStartupComplete = moduleLoader.isStartupComplete(); - boolean showSearch = isStartupComplete && PageFlowUtil.urlProviderOptional(SearchUrls.class) != null; HtmlView headerHtml = new HeaderProperties(getContainer()).getView(); String siteShortName = (laf.getShortName() != null && !laf.getShortName().isEmpty()) ? laf.getShortName() : null; @@ -139,7 +139,12 @@ %>