Skip to content

framebuffer panning does not work #4

Description

@altomaltes

Does not work for other yoffset than 0.

The problem may be owlfb-main.c

A comment can make the if take control over next line.

This is original code:

if (var->xoffset == fbi->var.xoffset && var->yoffset == fbi->var.yoffset)
// return 0;

new_var = fbi->var;
new_var.xoffset = var->xoffset;
new_var.yoffset = var->yoffset;

This comment >> // return 0;
Makes this line unactive on pan change >> new_var = fbi->var;

POSSIBLE FIX: add brackets

if (var->xoffset == fbi->var.xoffset &&
var->yoffset == fbi->var.yoffset)
{
//return 0;
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions