From 519e5078c4d71a5c48542e73d33632f723598073 Mon Sep 17 00:00:00 2001 From: TianKai Ma Date: Thu, 27 Aug 2026 18:13:05 +0800 Subject: [PATCH] fix(ci): report contract skip only for curriculum failures --- tests/test_verify_build.py | 16 +++++++++++++++- tools/verify_build.py | 3 +-- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/tests/test_verify_build.py b/tests/test_verify_build.py index ccfade62a3..674a728a4c 100644 --- a/tests/test_verify_build.py +++ b/tests/test_verify_build.py @@ -3,10 +3,24 @@ import unittest from pathlib import Path -from tools.verify_build import verify_build +from tools.verify_build import _write_status_summary, verify_build class BuildVerificationTest(unittest.TestCase): + def test_non_curriculum_failure_does_not_claim_contracts_were_skipped(self) -> None: + with tempfile.TemporaryDirectory() as temporary_dir: + summary_path = Path(temporary_dir) / "summary.md" + _write_status_summary( + summary_path, + { + "curriculum": {"status": "ok"}, + "young": {"status": "failed"}, + "rss": {"status": "ok"}, + }, + ) + + self.assertNotIn("skipped", summary_path.read_text(encoding="utf-8")) + def test_failed_authenticated_builders_skip_missing_contract_report(self) -> None: with tempfile.TemporaryDirectory() as temporary_dir: root = Path(temporary_dir) diff --git a/tools/verify_build.py b/tools/verify_build.py index e0a2c76226..6ed4253f8d 100644 --- a/tools/verify_build.py +++ b/tools/verify_build.py @@ -58,10 +58,9 @@ def _write_status_summary( summary_path: Path | None, builders: dict[str, dict[str, str]], ) -> None: - failed = [name for name in BUILDER_NAMES if builders[name]["status"] != "ok"] lines = ["## Static build status\n\n", "| Builder | Status |\n", "|---|---|\n"] lines.extend(f"| {name} | {builders[name]['status']} |\n" for name in BUILDER_NAMES) - if failed: + if builders["curriculum"]["status"] != "ok": lines.extend( [ "\n",