Skip to content

renderRoot Readability of do-while loop #5

Description

@CMenne

Do-While Loops

1. Do-while loop with a true conditional isn’t very readable.

2. A do-while loop with a break at the end isn’t indicative of the purpose of the do-while loop

Lines:
  • 1298
What we intend to do:
  • Change the while conditional so it better describes the purpose of the loop

3. Nested conditionals can be extracted into their own function.

Lines:
  • 1242
  • 1263
What we intend to do:
  • Extract interior into its own function

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions