From 05a9374dad3b5a2496c93cf0c27740ef465fdec8 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 17:47:12 -0600 Subject: [PATCH 01/10] use mise in travis --- .travis.yml | 39 ++++++++++++++++++++++++++++----------- mise.toml | 2 ++ 2 files changed, 30 insertions(+), 11 deletions(-) create mode 100644 mise.toml diff --git a/.travis.yml b/.travis.yml index 815a11c..de9509c 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,17 +1,34 @@ -language: ruby -cache: bundler +language: generic sudo: false -gemfile: - - gemfiles/rails_6.gemfile - - gemfiles/rails_7.gemfile - - gemfiles/rails_8.gemfile +cache: + directories: + - $HOME/.local/share/mise + - vendor/bundle -rvm: - - 3.2 - - 3.3 - - 3.4 - - 4.0 +env: + - RUBY_VERSION=3.2 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile + - RUBY_VERSION=3.2 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile + - RUBY_VERSION=3.2 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile + - RUBY_VERSION=3.3 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile + - RUBY_VERSION=3.3 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile + - RUBY_VERSION=3.3 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile + - RUBY_VERSION=3.4 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile + - RUBY_VERSION=3.4 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile + - RUBY_VERSION=3.4 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile + - RUBY_VERSION=4.0 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile + - RUBY_VERSION=4.0 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile + - RUBY_VERSION=4.0 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile + +before_install: + - curl https://mise.run | sh + - export PATH="$HOME/.local/bin:$PATH" + - mise install ruby@$RUBY_VERSION + - eval "$(mise env --shell bash ruby@$RUBY_VERSION)" + - ruby -v + +install: + - bundle install --jobs=3 --retry=3 --path vendor/bundle notifications: email: diff --git a/mise.toml b/mise.toml new file mode 100644 index 0000000..96bdb30 --- /dev/null +++ b/mise.toml @@ -0,0 +1,2 @@ +[tools] +ruby = "4" From ca0d76a59c259b63fd85a969eff1d5a51df00fb7 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 17:47:36 -0600 Subject: [PATCH 02/10] fix coveralls --- spec/spec_helper.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 38f7613..145c0a2 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -11,8 +11,6 @@ add_filter '/spec/' end -Coveralls.wear! - Dir['./spec/support/**/*.rb'].each { |f| require f } RSpec.configure do |config| From a436df9a17f19c6c73f9001926a904bedde6849e Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 17:50:21 -0600 Subject: [PATCH 03/10] use new ubocop:disable-next --- lib/mifiel/document.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/mifiel/document.rb b/lib/mifiel/document.rb index 61bbb81..9e33ab5 100644 --- a/lib/mifiel/document.rb +++ b/lib/mifiel/document.rb @@ -23,7 +23,7 @@ class Document < Mifiel::Base post :create_from_template, '/templates/:template_id/generate_document', timeout: 60 post :create_many_from_template, '/templates/:template_id/generate_documents', timeout: 60 - # rubocop:disable Metrics/MethodLength + # rubocop:disable-next Metrics/MethodLength def self.create(args) signatories = args[:signatories] file = args[:file] @@ -43,7 +43,6 @@ def self.create(args) payload = args.merge(payload).compact process_request('/documents', :post, payload: payload, type: :form_multipart) end - # rubocop:enable Metrics/MethodLength # @deprecated def request_signature(email, cc: nil) From b9127a9c19c6fd49bdff8ca2fe046cddb4f5d298 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 18:46:15 -0600 Subject: [PATCH 04/10] check ruby on focal amd64 --- .travis.yml | 42 ++++++++++++++---------------------------- 1 file changed, 14 insertions(+), 28 deletions(-) diff --git a/.travis.yml b/.travis.yml index de9509c..f3a9f4b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,34 +1,20 @@ -language: generic +os: linux +dist: focal +arch: amd64 +language: ruby +cache: bundler sudo: false -cache: - directories: - - $HOME/.local/share/mise - - vendor/bundle +gemfile: + - gemfiles/rails_6.gemfile + - gemfiles/rails_7.gemfile + - gemfiles/rails_8.gemfile -env: - - RUBY_VERSION=3.2 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile - - RUBY_VERSION=3.2 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile - - RUBY_VERSION=3.2 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile - - RUBY_VERSION=3.3 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile - - RUBY_VERSION=3.3 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile - - RUBY_VERSION=3.3 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile - - RUBY_VERSION=3.4 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile - - RUBY_VERSION=3.4 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile - - RUBY_VERSION=3.4 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile - - RUBY_VERSION=4.0 BUNDLE_GEMFILE=gemfiles/rails_6.gemfile - - RUBY_VERSION=4.0 BUNDLE_GEMFILE=gemfiles/rails_7.gemfile - - RUBY_VERSION=4.0 BUNDLE_GEMFILE=gemfiles/rails_8.gemfile - -before_install: - - curl https://mise.run | sh - - export PATH="$HOME/.local/bin:$PATH" - - mise install ruby@$RUBY_VERSION - - eval "$(mise env --shell bash ruby@$RUBY_VERSION)" - - ruby -v - -install: - - bundle install --jobs=3 --retry=3 --path vendor/bundle +rvm: + - 3.2 + - 3.3 + - 3.4 + - 4.0 notifications: email: From 6f32639bbfcd120d85599230badff59e8ce1c0de Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 18:46:31 -0600 Subject: [PATCH 05/10] check only ruby 4 --- .travis.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index f3a9f4b..a86bd49 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,9 +11,9 @@ gemfile: - gemfiles/rails_8.gemfile rvm: - - 3.2 - - 3.3 - - 3.4 + # - 3.2 + # - 3.3 + # - 3.4 - 4.0 notifications: From 26dc6aff826f751a4e3fcf71177eda5179ec1881 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 18:51:39 -0600 Subject: [PATCH 06/10] Add more jobs for ruby 4.0 --- .travis.yml | 31 +++++++++++++++++++++++++++---- 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index a86bd49..bf7aa78 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,10 +11,33 @@ gemfile: - gemfiles/rails_8.gemfile rvm: - # - 3.2 - # - 3.3 - # - 3.4 - - 4.0 + - 3.2 + - 3.3 + - 3.4 + +# Travis runs `rvm use` before before_install, so `rvm: 4.0` fails on stable +# RVM. Bootstrap from a known Ruby, then upgrade RVM only on these jobs. +jobs: + include: + - rvm: 3.3 + gemfile: gemfiles/rails_6.gemfile + env: INSTALL_RUBY=4.0 + - rvm: 3.3 + gemfile: gemfiles/rails_7.gemfile + env: INSTALL_RUBY=4.0 + - rvm: 3.3 + gemfile: gemfiles/rails_8.gemfile + env: INSTALL_RUBY=4.0 + +before_install: + - | + if [ -n "$INSTALL_RUBY" ]; then + rvm get master + rvm reload + rvm install "$INSTALL_RUBY" + rvm use "$INSTALL_RUBY" + ruby -v + fi notifications: email: From 8732d6ccdbb1d27ebafe8aa7ee20210980f8f281 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 18:57:17 -0600 Subject: [PATCH 07/10] drop support for eol rails 6 --- .travis.yml | 4 ---- Appraisals | 7 ------- gemfiles/rails_6.gemfile | 24 ------------------------ 3 files changed, 35 deletions(-) delete mode 100644 gemfiles/rails_6.gemfile diff --git a/.travis.yml b/.travis.yml index bf7aa78..ffbb302 100644 --- a/.travis.yml +++ b/.travis.yml @@ -6,7 +6,6 @@ cache: bundler sudo: false gemfile: - - gemfiles/rails_6.gemfile - gemfiles/rails_7.gemfile - gemfiles/rails_8.gemfile @@ -19,9 +18,6 @@ rvm: # RVM. Bootstrap from a known Ruby, then upgrade RVM only on these jobs. jobs: include: - - rvm: 3.3 - gemfile: gemfiles/rails_6.gemfile - env: INSTALL_RUBY=4.0 - rvm: 3.3 gemfile: gemfiles/rails_7.gemfile env: INSTALL_RUBY=4.0 diff --git a/Appraisals b/Appraisals index df8942c..262d0e6 100644 --- a/Appraisals +++ b/Appraisals @@ -1,12 +1,5 @@ # frozen_string_literal: true -appraise 'rails-6' do - gem 'rails', '6' - gem 'mutex_m' - gem 'benchmark' - gem 'ostruct' -end - appraise 'rails-7' do gem 'rails', '7' gem 'mutex_m' diff --git a/gemfiles/rails_6.gemfile b/gemfiles/rails_6.gemfile deleted file mode 100644 index f02041e..0000000 --- a/gemfiles/rails_6.gemfile +++ /dev/null @@ -1,24 +0,0 @@ -# This file was generated by Appraisal - -source "https://rubygems.org" - -gem "rails", "6" -gem "mutex_m" -gem "benchmark" -gem "ostruct" - -group :development, :test do - gem "coveralls", require: false - gem "pry" - gem "rubocop" - gem "rubocop-rake" - gem "rubocop-rspec" - gem "appraisal" - gem "rake" - gem "rspec" - gem "simplecov" - gem "sinatra" - gem "webmock" -end - -gemspec path: "../" From 88872a046f24bd4ccf41445e871e6b79ebc31472 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 18:58:30 -0600 Subject: [PATCH 08/10] drop support for oel ruby 3.2 --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index ffbb302..35bc277 100644 --- a/.travis.yml +++ b/.travis.yml @@ -10,7 +10,6 @@ gemfile: - gemfiles/rails_8.gemfile rvm: - - 3.2 - 3.3 - 3.4 From fcb0e20839fa61a4005853da6babf15af6739367 Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 19:02:19 -0600 Subject: [PATCH 09/10] test github workflows --- .github/workflows/ci.yml | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) create mode 100644 .github/workflows/ci.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml new file mode 100644 index 0000000..6898ba2 --- /dev/null +++ b/.github/workflows/ci.yml @@ -0,0 +1,29 @@ +name: CI + +on: + push: + +jobs: + test: + runs-on: ubuntu-latest + strategy: + fail-fast: false + matrix: + ruby: ['3.3', '3.4', '4.0'] + gemfile: + - gemfiles/rails_7.gemfile + - gemfiles/rails_8.gemfile + env: + BUNDLE_GEMFILE: ${{ matrix.gemfile }} + steps: + - uses: actions/checkout@v7 + - uses: ruby/setup-ruby@v1 + with: + ruby-version: ${{ matrix.ruby }} + bundler-cache: true + - name: Create tmp dir + run: mkdir -p tmp + - name: RuboCop + run: bundle exec rubocop + - name: RSpec + run: bundle exec rspec From 1ef1a3cb96d529c6cbe8eedbb271d7834483565d Mon Sep 17 00:00:00 2001 From: Genaro Madrid Date: Mon, 24 Aug 2026 19:04:07 -0600 Subject: [PATCH 10/10] remove slow travis testing --- .travis.yml | 45 --------------------------------------------- 1 file changed, 45 deletions(-) delete mode 100644 .travis.yml diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index 35bc277..0000000 --- a/.travis.yml +++ /dev/null @@ -1,45 +0,0 @@ -os: linux -dist: focal -arch: amd64 -language: ruby -cache: bundler -sudo: false - -gemfile: - - gemfiles/rails_7.gemfile - - gemfiles/rails_8.gemfile - -rvm: - - 3.3 - - 3.4 - -# Travis runs `rvm use` before before_install, so `rvm: 4.0` fails on stable -# RVM. Bootstrap from a known Ruby, then upgrade RVM only on these jobs. -jobs: - include: - - rvm: 3.3 - gemfile: gemfiles/rails_7.gemfile - env: INSTALL_RUBY=4.0 - - rvm: 3.3 - gemfile: gemfiles/rails_8.gemfile - env: INSTALL_RUBY=4.0 - -before_install: - - | - if [ -n "$INSTALL_RUBY" ]; then - rvm get master - rvm reload - rvm install "$INSTALL_RUBY" - rvm use "$INSTALL_RUBY" - ruby -v - fi - -notifications: - email: - on_success: change - on_failure: always - -script: - - mkdir ./tmp/ - - bundle exec rubocop - - bundle exec rspec