Found an issue when using a base class with [Timestamp] attribute on it

[ste4net]

As i wrote in #20 I have likely identified the following issue:
Code is not generated correctly if a class with the [Partial] attribute inherits from a base class that uses the [Timestamp] attribute (System.ComponentModel.DataAnnotations).
This issue occurs only if the base class is located in a different assembly.
However, in the case of < EmitCompilerGeneratedFiles >true< /EmitCompilerGeneratedFiles >, the physical files are still generated correctly.

Case one (not working)...

//...[another assembly
    public class SImpleBase
    {
        [Timestamp]
        public byte[] RowVersion { get; set; } = new byte[8];
         
    }
 //...[another assembly
    [Partial]
    public class Prova : SImpleBase
    {
        public string Surname { get; set; }
        public string Name { get; set; }
    }

Case one (working)...

public class SImpleBase2
    {
        [Timestamp]
        public byte[] RowVersion { get; set; } = new byte[8];

    }
    [Partial]
    public class Prova : SImpleBase2
    {
        public string Surname { get; set; }
        public string Name { get; set; }
    }

[Newex]

I have tried to implement such that each property in parent objects are included.

But it is quite complicated for me, to correctly enumerate the properties when they are defined in another assembly.

The problem is not due to the timestamp attribute, it seems to be because it is quite difficult to retrieve the definitions across assemblies.

The current solution in the branch bug/inheritance_across_assemblies only does a basic retrieval of property definitions.

Example

First in the base assembly we have the definition:

public record MyBaseType
{
  [Timestamp]
  public byte[] Timestamp
  {
    private byte[] timestamp;
    get
    {
      // Manipulate backing field: timestamp and then return -->
      return timestamp;
    }
    set
    {
      // Do some validation of the backing field
      timestamp = value;
    }
  }
}

Then in another assembly:

[Partial]
public record MyType : MyBaseType
{
}

The output will not retain the any logic in the getter or setter, or keep any attributes, or use any PartialSourceGen attributes (except: ExcludePartial).

Output:

public partial record PartialMyType
{
  public byte[]? Timestamp { get; set; }
}

Status

This is the current solution in the bug branch. I am thinking about merging and pushing this into the next version. Unfortunately this is the best I can do, unless someone with more knowledge can fix it.

The reason I think it will work like this is because I have created 2 snapshot tests and they seem to be working, but I don't know if they solve your problem.