From 22b84edf435761771011ba5d4c1895905e6e9a56 Mon Sep 17 00:00:00 2001 From: PonceGL Date: Thu, 10 Sep 2026 06:52:27 -0600 Subject: [PATCH 1/2] =?UTF-8?q?fix(github):=20P.8=20=E2=80=94=20point=20Gi?= =?UTF-8?q?tHub=20services=20at=20the=20renamed=20repo?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fetchPlayStoreAnnouncement() defaulted to owner=theovilardo, repo=PixelPlay — the project's name before the rename to PixelPlayerHQ/PixelPlayer. Works today only because raw.githubusercontent.com still resolves the old path (verified: both URLs return identical content, same etag) — a silent dependency on nobody claiming the old name. Points the defaults at the real repo. Single caller (MainActivity.kt:758) uses no arguments, so this is the only thing that needed to change there. Self-review (code-review skill) found the identical problem in the sibling GitHubContributorService.fetchContributors(), same owner/repo defaults, powering the About screen's contributor list (AboutScreen.kt:202, also called with no arguments) — not named in the original plan, but the same bug. Confirmed empirically: unlike the raw-content case, api.github.com/repos/theovilardo/PixelPlay returns an actual HTTP 301, not a silent 200 — one redirect hop this fix now removes entirely rather than leaving it to keep working by GitHub's grace. Fixed with the same one-line-per-default change. No test added in either file: this predates P.9's genericization of GitHubAnnouncementPropertiesService (fetchRawProperties, separate branch, unmerged) which is what makes that service testable without hitting real network — redoing that refactor here would duplicate P.9's own scope, and GitHubContributorService has no equivalent seam at all. Nothing to assert about a default string value without one. Baseline: 5 pre-existing failures, none new. assembleDebug succeeds. --- .../data/github/GitHubAnnouncementPropertiesService.kt | 4 ++-- .../pixelplay/data/github/GitHubContributorService.kt | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubAnnouncementPropertiesService.kt b/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubAnnouncementPropertiesService.kt index d540ad1cae..ff6d2794e7 100644 --- a/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubAnnouncementPropertiesService.kt +++ b/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubAnnouncementPropertiesService.kt @@ -36,8 +36,8 @@ class GitHubAnnouncementPropertiesService @Inject constructor() { * - play_store_link_pending_message */ suspend fun fetchPlayStoreAnnouncement( - owner: String = "theovilardo", - repo: String = "PixelPlay", + owner: String = "PixelPlayerHQ", + repo: String = "PixelPlayer", branch: String = "master", configPath: String = "remote-config/app-announcements.properties", ): Result { diff --git a/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubContributorService.kt b/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubContributorService.kt index 7f963aed68..900ee86f9b 100644 --- a/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubContributorService.kt +++ b/app/src/main/java/com/theveloper/pixelplay/data/github/GitHubContributorService.kt @@ -25,8 +25,8 @@ class GitHubContributorService @Inject constructor() { * Fetches contributors from the GitHub repository */ suspend fun fetchContributors( - owner: String = "theovilardo", - repo: String = "PixelPlay" + owner: String = "PixelPlayerHQ", + repo: String = "PixelPlayer" ): Result> { return withContext(Dispatchers.IO) { try { From 4404b60698c9d671010ecf64b9b6cb0941b36282 Mon Sep 17 00:00:00 2001 From: PonceGL Date: Thu, 10 Sep 2026 18:25:21 -0600 Subject: [PATCH 2/2] fix(github): point remaining hardcoded repo URLs at PixelPlayerHQ/PixelPlayer MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit code-review on PR #34 found the rename missed 4 more hardcoded URLs beyond the two services this PR already updated: - AboutScreen.kt's 'Open GitHub repo' chip - BetaInfoBottomSheet's issues/report links - ChangelogBottomSheet's changelog link - GenericOpenAiClient's OpenRouter HTTP-Referer attribution header Verified both the old and new URLs: old owner/repo now only 301s, new owner/repo resolves live (200) on both raw.githubusercontent.com and api.github.com. Left untouched on purpose: AboutScreen.kt's "theovilardo" references (the maintainer's personal GitHub account, not the repo), and README.md/CHANGELOG.md (the latter is a historical record of past PRs and shouldn't be rewritten). A fifth finding — the owner/repo pair is duplicated as string literals in 6+ places, which is exactly why the rename missed spots — was left for a follow-up: a shared GitHubRepo.OWNER/REPO constant is a real fix but a structural change beyond this diff. Verified: compiles, full JVM suite green (388 tests, same 5 pre-existing baseline failures as master, none new). --- .../pixelplay/data/ai/provider/GenericOpenAiClient.kt | 2 +- .../pixelplay/presentation/components/BetaInfoBottomSheet.kt | 4 ++-- .../pixelplay/presentation/components/ChangelogBottomSheet.kt | 2 +- .../theveloper/pixelplay/presentation/screens/AboutScreen.kt | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/theveloper/pixelplay/data/ai/provider/GenericOpenAiClient.kt b/app/src/main/java/com/theveloper/pixelplay/data/ai/provider/GenericOpenAiClient.kt index fd0fb1c1d8..0a08d25191 100644 --- a/app/src/main/java/com/theveloper/pixelplay/data/ai/provider/GenericOpenAiClient.kt +++ b/app/src/main/java/com/theveloper/pixelplay/data/ai/provider/GenericOpenAiClient.kt @@ -96,7 +96,7 @@ class GenericOpenAiClient( .addHeader("Content-Type", "application/json") if (providerName.equals("OpenRouter", ignoreCase = true)) { - requestBuilder.addHeader("HTTP-Referer", "https://github.com/theovilardo/PixelPlayer") + requestBuilder.addHeader("HTTP-Referer", "https://github.com/PixelPlayerHQ/PixelPlayer") requestBuilder.addHeader("X-Title", "PixelPlayer") } diff --git a/app/src/main/java/com/theveloper/pixelplay/presentation/components/BetaInfoBottomSheet.kt b/app/src/main/java/com/theveloper/pixelplay/presentation/components/BetaInfoBottomSheet.kt index 0370ac54df..df880af85e 100644 --- a/app/src/main/java/com/theveloper/pixelplay/presentation/components/BetaInfoBottomSheet.kt +++ b/app/src/main/java/com/theveloper/pixelplay/presentation/components/BetaInfoBottomSheet.kt @@ -71,8 +71,8 @@ import racra.compose.smooth_corner_rect_library.AbsoluteSmoothCornerShape @Composable fun BetaInfoBottomSheet(modifier: Modifier = Modifier) { val context = LocalContext.current - val issuesUrl = "https://github.com/theovilardo/PixelPlayer/issues" - val reportUrl = "https://github.com/theovilardo/PixelPlayer/issues/new/choose" + val issuesUrl = "https://github.com/PixelPlayerHQ/PixelPlayer/issues" + val reportUrl = "https://github.com/PixelPlayerHQ/PixelPlayer/issues/new/choose" val fabCornerRadius = 18.dp diff --git a/app/src/main/java/com/theveloper/pixelplay/presentation/components/ChangelogBottomSheet.kt b/app/src/main/java/com/theveloper/pixelplay/presentation/components/ChangelogBottomSheet.kt index 5d8a3860d1..1d7b4c7f0b 100644 --- a/app/src/main/java/com/theveloper/pixelplay/presentation/components/ChangelogBottomSheet.kt +++ b/app/src/main/java/com/theveloper/pixelplay/presentation/components/ChangelogBottomSheet.kt @@ -132,7 +132,7 @@ fun ChangelogBottomSheet( modifier: Modifier = Modifier ) { val context = LocalContext.current - val changelogUrl = "https://github.com/theovilardo/PixelPlayer/blob/master/CHANGELOG.md" + val changelogUrl = "https://github.com/PixelPlayerHQ/PixelPlayer/blob/master/CHANGELOG.md" val changelog = changelogVersions() val fabCornerRadius = 16.dp diff --git a/app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt b/app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt index f1050c4b3d..c56a1aa2e8 100644 --- a/app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt +++ b/app/src/main/java/com/theveloper/pixelplay/presentation/screens/AboutScreen.kt @@ -663,7 +663,7 @@ private fun AboutHeroCard( subtitle = stringResource(R.string.about_github_subtitle), iconRes = R.drawable.github, contentDescription = stringResource(R.string.about_cd_open_github_repo), - onClick = { openUrl(context, "https://github.com/theovilardo/PixelPlayer") }, + onClick = { openUrl(context, "https://github.com/PixelPlayerHQ/PixelPlayer") }, modifier = Modifier.weight(1f), ) SocialChip(