Skip to content

Commit 408d5fc

Browse files
committed
fix tests
1 parent 6bfe9c6 commit 408d5fc

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

backend/app/tests/crud/evaluations/test_fast_judge.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -952,7 +952,7 @@ def test_summary_brief_carries_the_scored_traces(
952952
assert BOT_INSTRUCTIONS in brief
953953
payload = json.loads(brief.split("## Per-question judge traces (JSON)\n", 1)[1])
954954

955-
assert [trace["trace_id"] for trace in payload] == ["item-1"]
955+
assert [trace["question_id"] for trace in payload] == ["item-1"]
956956
assert payload[0]["question"] == "Q1"
957957
assert payload[0]["ground_truth_answer"] == "golden-1"
958958
assert payload[0]["llm_answer"] == "generated for Q1"

backend/app/tests/crud/evaluations/test_judge.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -293,15 +293,16 @@ def test_empty_question_drops_ground_truth(self) -> None:
293293
class TestBuildJudgeParams:
294294
"""FR-9: system-config judging uses the fallback model + built-in ground-truth prompt.
295295
296-
The judge is a reasoning model (gpt-5-mini) that rejects a custom temperature, so
297-
the request never carries one.
296+
`build_judge_params` never sets a temperature, so the body never carries one.
297+
The judge model has no `model_config` row, so the mapper reads it as
298+
non-reasoning and drops `EVAL_JUDGE_REASONING_EFFORT` from the request.
298299
"""
299300

300301
def test_defaults_to_fallback_model_and_builtin_prompt(self, db: Session) -> None:
301302
base_params = build_judge_params(session=db)
302303

303304
assert base_params["model"] == settings.EVAL_JUDGE_MODEL
304-
assert base_params["model"] == "gpt-5-mini"
305+
assert base_params["model"] == "gpt-5.6-luna"
305306
assert "temperature" not in base_params
306307
# Instructions are the per-row applicable-metric subset, so they are composed
307308
# in judge_row, never baked into the shared base params.

0 commit comments

Comments
 (0)