Skip to content

Progress deprecation of substitute() on LHS of := #6649

Description

@MichaelChirico

data.table/R/data.table.R

Lines 1133 to 1136 in 436bd6c

#6033 revdep. Slowly deprecate in 1.17.0. Caller has given us `dt[, substitute(names(.SD))]` which means
# jsub is actually substitute(names(.SD)) instead of just names(.SD)
if (lhs %iscall% 'substitute')
lhs = eval(lhs, parent.frame(), parent.frame())

Assigning to @ColeMiller1 who I think has the best context on what to do next here. Should we just add an appropriate warning in this branch?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

breaking-changeissues whose solution would require breaking existing behavior

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions