Skip to content

Commit ff5bba8

Browse files
committed
feat: ghcr for client python
1 parent 6a1fdac commit ff5bba8

2 files changed

Lines changed: 10 additions & 4 deletions

File tree

.github/workflows/build-docker.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@ concurrency:
99
group: build-python-client
1010
cancel-in-progress: false
1111

12+
permissions:
13+
contents: read
14+
packages: write
15+
16+
1217
jobs:
1318
build:
1419
strategy:
@@ -22,9 +27,6 @@ jobs:
2227
platform: linux/arm64
2328
runner: ubuntu-22.04-arm
2429
runs-on: ${{ matrix.runner }}
25-
permissions:
26-
contents: read
27-
packages: write
2830

2931
steps:
3032
- name: Record job start time
@@ -109,7 +111,7 @@ jobs:
109111

110112
- name: Create and push multi-arch manifest
111113
run: |
112-
IMAGE=ghcr.io/${{ github.repository_owner }}/intercom-python-client
114+
IMAGE=ghcr.io/splintercom/intercom-python-client
113115
APP_VERSION=$(cat VERSION)
114116
DOCKER_TAG=$(echo "$APP_VERSION" | tr '+' '-')
115117

main.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ def __init__(self, config: Config):
4141
self.peer_connections: dict[str, RTCPeerConnection] = {}
4242
self.camera_tracks: dict[str, CameraVideoStreamTrack] = {}
4343
self._camera_source: SharedCameraSource | None = None
44+
self.pc = None
4445
self.ws = None
4546
self.running = True
4647
self.turn_credentials: dict | None = None
@@ -367,6 +368,9 @@ async def shutdown(self):
367368

368369
await self._cleanup_connections()
369370

371+
if self.pc:
372+
await self.pc.close()
373+
370374
if self.ws:
371375
await self.ws.close()
372376

0 commit comments

Comments
 (0)