Skip to content

fix(appraisal): reject credentials embedded in RPC URLs #257

Description

@karagozemin

Problem

Appraisal API configuration accepts RPC URLs containing a username or password. Embedded credentials can leak through diagnostics, process inspection, or copied configuration.

Task

Reject HTTP or HTTPS RPC URLs whose parsed URL contains credentials. Preserve all existing URL and network behavior.

Acceptance criteria

  • URLs with a username, password, or both are rejected with an AppraisalConfigError.
  • Normal HTTP and HTTPS RPC URLs remain valid.
  • The error does not echo credential contents.
  • Appraisal configuration tests and typecheck pass.

Suggested implementation prompt

Add credential checks to appraisal RPC URL parsing, write focused tests for username and password URLs plus a valid control case, ensure errors do not reveal credentials, and keep the diff scoped.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GrantFox OSSIssue tracked in GrantFox OSSMaybe RewardedIssue may be eligible for a GrantFox rewardThird CampaignCampaign: Third Campaign

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions