Skip to content

Need to disambiguate the use of the word json in the code base #2

Description

@NickChapman

There are methods for certain models called "get_json" that return the "json representation" which is actually just a dictionary. Of course these dictionaries can be easily converted to json using json.dump[s]. We just need to decide whether we want to return actual json or if we want to change the name of the method to something like get_json_compatible_object.

My reasoning behind this being that down the line it will be confusing to have code that looks like:

json_string = json.dumps(something.get_json())

when you would expect it to be

json_string = something.get_json()

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions