[Bug]: Downloaded artifacts lack Content-Length

[gohoski]

What happened?

It seems that the server doesn't add Content-Length to the downloader's artifact URL. This means that the download's file size is not shown in the download list, so e.g. no download time estimation could be done and it is unclear how much of the file has been downloaded. I suggest that Content-Length should be added. I don't know if this is an issue of the Kotlin server or the Go downloader, so I don't think I can provide any specific details. I also don't know if adding Content-Length is even feasible, but I assume so, as the video has been downloaded and muxed by the instance.

Thank you very much for this awesome project! It is the only YouTube frontend that fully implements SABR and is optimized. The fact that BiliBili and NicoNico are also accessible is also amazing.

Steps to reproduce

1. Go to a YouTube video
2. Click the Download button
3. Select any quality and download
4. See that the downloaded file doesn't have file size displayed and the estimated time is unavailable. This is also evident by the absence of Content-Length in the /downloader/jobs/{id}/artifact response.

Area

Downloader

Channel

No response

Anything else?

No response

[Priveetee]

Thx for the detailed report, and thx a lot for the kind words about TypeType! My experience contributing to PipePipe helped a lot in building this project. It took a lot of time to get here, but the result is finally there and I’m proud of it. I’m also really happy to talk with people who are as enthusiastic about TypeType as I am!

I tested this on the current beta with a real completed download, and u are right. The Downloader knows the exact file size, but Content-Length is lost when Server proxies the artifact back to the browser. Normal GET, HEAD and range responses are all affected.

So this is feasible to fix and the problem is on the Server side. I’ll fix the proxy response and add a regression test that covers the real production server behavior.