Skip to content

Storing passwords #60

Description

@otajor

Just made this comment on another repo and I know you might not have covered this yet. However:

Looks like you're storing passwords in plain text and then just comparing the user input to what you have in the database when the user logs in.

This is pretty bad practice because if someone steals your database they will have all the user passwords. To prevent this you should hash and salt your passwords and never store the actual plain text password, ever.

Don't really expect you to fix this in a couple of hours code review, but maybe check out how this group did it here:
https://github.com/FAC9/the-badgerer/blob/master/src/handlers/loginHandler.js
and here:
https://github.com/FAC9/the-badgerer/blob/master/src/handlers/newUserHandler.js

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions