From ac717fc5414ebd7cf6e3a3595738590403d73504 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= <mail@kraenhansen.dk>
Date: Sun, 9 Aug 2026 21:11:51 +0200
Subject: [PATCH] ci: drop the `--` separator when forwarding args through pnpm
 run
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

npm and pnpm disagree on `npm/pnpm run <script> -- <args>`: npm swallows the
separator and appends only the args, pnpm appends the separator verbatim. The
migration in #381 rewrote these call sites mechanically, so the `--` started
leaking into the scripts' own argv.

For `packages/ferric-example` this is a hard failure — the script is
`ferric build`, so it ran as `ferric build -- --android`, commander read `--`
as the options terminator and `--android` became a positional operand of a
subcommand that takes none:

    error: too many arguments for 'build'. Expected 0 arguments but got 1.

For the `test:*:allTests` scripts (which end in `-- ` so `node --run` forwards
to the inner script) it is subtler: the extra separator survives as a literal
`--` in the forwarded args, ahead of `--mode Release`.

Dropping the separator restores exactly the argv these steps had under npm.

This only shows up on PRs labeled "Android 🤖": test-android is gated to those
while the self-hosted runner is offline (#379), so nothing had exercised the
Android lane since #381 landed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 .github/workflows/check.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml
index 50dccd4a..c376521b 100644
--- a/.github/workflows/check.yml
+++ b/.github/workflows/check.yml
@@ -181,7 +181,7 @@ jobs:
       - name: Run tests (iOS)
         run: pnpm run test:ios:allTests
         # TODO: Enable release mode when it works
-        # run: pnpm run test:ios:allTests -- --mode Release
+        # run: pnpm run test:ios:allTests --mode Release
         working-directory: apps/test-app
   test-macos:
     # Disabling this on main for now, as initializing the template takes a long time and
@@ -291,7 +291,7 @@ jobs:
       - name: Build weak-node-api for all Android architectures
         run: pnpm --filter weak-node-api run prebuild:build:android
       - name: Build ferric-example for all architectures
-        run: pnpm run build -- --android
+        run: pnpm run build --android
         working-directory: packages/ferric-example
       - name: Run tests (Android)
         timeout-minutes: 75
@@ -313,7 +313,7 @@ jobs:
             adb logcat > emulator-logcat.txt 2>&1 &
             LOGCAT_PID=$!
             # Build, install and run the app
-            pnpm run test:android:allTests -- --mode Release
+            pnpm run test:android:allTests --mode Release
             # Wait a bit for the sub-process to terminate, before terminating the emulator
             sleep 5
             # Stop logcat