Skip to content

cril (introduce let) does not properly indent the body of the new let form #21

Description

@daveyarwood

For example, I have this top-level form:

(defrpc campaigns
  [& [opts]]
  {:rpc/pre (and (have-api-key) (have-network))}
  (->> (view/campaigns (network) opts)
       (map #(safe-parse-json % :customfields))))

When I put my cursor on the ( before ->> and enter cril and enter cs for the binding name, the result is:

(defrpc campaigns
  [& [opts]]
  {:rpc/pre (and (have-api-key) (have-network))}
  (let [cs (->> (view/campaigns (network) opts))]
       (map #(safe-parse-json % :customfields))))
cs

I use parinfer, so it re-balanced my parens because cs was all the way to the left, so it was judged to be another top-level form. The bindings part of the let also got closed prematurely because the line after it wasn't indented far enough to the right.

If I disable parinfer and do the same thing, I get this, which is still not indented properly:

(defrpc campaigns
  [& [opts]]
  {:rpc/pre (and (have-api-key) (have-network))}
  (let [cs (->> (view/campaigns (network) opts)
       (map #(safe-parse-json % :customfields)))]
cs))

Note that not only is cs not indented at all, the previous line also has incorrect indentation now because it didn't move from where it was before.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions