Skip to content

Fretboard overlay plugin: notes misaligned on bass/7-string charts (hardcoded 6 strings) #60

Description

@carochacs

Summary

The fretboard plugin's overlay hardcodes a 6-string grid (FB_STRINGS = 6 in screen.js) and maps chart note string indices straight onto those 6 rows without ever calling highway.getStringCount(). On a 4-string bass arrangement this puts highlighted notes two rows off from where they're actually played (and the string labels e/B/G/D/A/E don't apply to a bass at all); 7/8-string GP imports have the inverse problem.

Tracked upstream in the plugin's own repo: got-feedBack/feedBack-plugin-fretboard#19

Repro

Play a bass (4-string) or extended-range (7/8-string) arrangement with the fretboard overlay toggled on — highlighted fret/string dots don't line up with the string the note is actually on.

Why here too

This repo vendors plugins/fretboard/ — filing here as well so it's visible against this deployment's plugin set until the upstream fix lands and gets synced in.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions