Skip to content

Make --reset-peers-on-error configurable via values #3

Description

@dimoschi

Problem

--reset-peers-on-error is currently hardcoded in the StatefulSet template (line 49 of templates/statefulset.yaml). This flag causes Typesense to reset all peer connections whenever a peer error is encountered.

During normal catch-up after a pod restart or node join, transient peer errors are common. With this flag always enabled, those errors trigger peer resets which cause additional Raft membership churn, compounding instability in an already-recovering cluster.

Proposed Change

Make the flag opt-in via a values key, e.g.:

typesense:
  resetPeersOnError: true  # default: true to preserve current behaviour

In the template:

{{- if .Values.typesense.resetPeersOnError }}
- "--reset-peers-on-error"
{{- end }}

Why

Operators running stable, well-provisioned clusters should be able to disable this to reduce unnecessary peer resets during catch-up, without having to fork the chart.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions