From b77e2d30f37d69e83374c8d389734c42f599b4e5 Mon Sep 17 00:00:00 2001 From: joshwheelock Date: Tue, 25 Aug 2026 22:52:02 +0200 Subject: [PATCH] Fix goal review verification guidance --- CHANGELOG.md | 4 ++++ assets/skills/review-jumbo-goal/SKILL.md | 17 ++++++++++------- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 689585f1..ecb444d5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed + +- **Goal review verification**: Managed review instructions now discover and run project-supported verification instead of assuming a specific package manager or ecosystem, preventing unrelated review rejections in nonmatching projects. + ## [3.21.0] - 2026-08-18 ### Added diff --git a/assets/skills/review-jumbo-goal/SKILL.md b/assets/skills/review-jumbo-goal/SKILL.md index e0ea9ee3..c5f08a35 100644 --- a/assets/skills/review-jumbo-goal/SKILL.md +++ b/assets/skills/review-jumbo-goal/SKILL.md @@ -62,13 +62,16 @@ For each category in the review output: If ANY entity constraint is violated: add the issues to the feedback list. -### 6. Run Tests +### 6. Run Applicable Verification -```bash -npm test -``` +Discover the project's verification commands from its repository instructions, build +manifests, and CI configuration. Run the tests and other checks that apply to the changed +scope using the project's own tooling. -All tests must pass. If tests fail: add the issues to the feedback list. +Record failures from applicable verification in the feedback list. Do not require +verification commands that the project does not define as applicable. If the project +defines no automated verification for the changed scope, record that fact as review +evidence rather than a failure. ### 7. Qualify or Re-Review @@ -87,8 +90,8 @@ jumbo goal reject --id --audit-findings ## Rules -1. **Never approve with unresolved failures.** Every criterion, invariant, and test must pass before approving. +1. **Never approve with unresolved failures.** Every criterion, invariant, and applicable verification must pass before approving. 2. **Never skip entity categories.** Review output includes entities for a reason — each was registered during refinement as essential context. -3. **Always run tests.** Implementation without passing tests is incomplete. +3. **Always run applicable verification.** Use the project's defined tools and commands; do not assume a package manager or ecosystem. 4. **Document issues clearly.** When rejecting a goal, provide detailed feedback for each failure. 5. **Read the code, don't assume.** Verify each criterion by reading actual implementation, not by recalling what you wrote.