Skip to content

TotalCompactions() returns max not sum — name is misleading #12

Description

@rajfirke

Description

TotalCompactions() takes the maximum compaction count across iterations. If compactions is a running counter, max is correct but the name is misleading. If per-iteration, the result is wrong.

Fix

Rename to MaxCompactions() or document the semantics.

Location

internal/trace/metrics.go:47-54

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't workinggood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions