Skip to content

Blob paste swallows setup errors and reports success #9177

Description

@craxal

Problem

pasteBlobsWithoutPrompt returns Promise<void> and swallows every setup error. The catch block logs to the activity log and then returns normally, so the caller cannot distinguish three very different outcomes: the paste succeeded, the user cancelled, or setup failed outright.

ErrorInsufficientCredentials routes through that same catch, so this is not emulator-only -- real Azure connections are affected. A user who lacks permission to read the source sees the operation appear to complete.

Evidence

  • PasteBlobs.ts:125-129 -- catch logs and returns
  • PasteBlobs.ts:43 -- signature is Promise<void>
  • index.ts:116 -- provider AzCopy.Blob.pasteBlobs returns it directly to the caller

Suggested fix

Return a discriminated result (succeeded / cancelled / failed) so callers can react, and let genuine setup failures surface to the user rather than resolving silently.

Found while automating the blob paste E2E cases.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions