diff --git a/Gemfile b/Gemfile index 0c15800..41652e9 100644 --- a/Gemfile +++ b/Gemfile @@ -2,5 +2,11 @@ source 'https://rubygems.org' +# concurrent-ruby >= 1.3.5 no longer requires "logger" itself, but +# activesupport 6.1 still references ::Logger at load time. Requiring +# it here in the Gemfile ensures it is loaded by bundler/setup before +# any gem loads active_support. +require "logger" + # Specify your gem's dependencies in active_remote-cached.gemspec gemspec diff --git a/active_remote-cached.gemspec b/active_remote-cached.gemspec index 36bbafe..35c7456 100644 --- a/active_remote-cached.gemspec +++ b/active_remote-cached.gemspec @@ -13,7 +13,7 @@ Gem::Specification.new do |gem| gem.email = ['brandonsdewitt@gmail.com', 'devexperience@mx.com'] gem.description = ' Provides "cached" finders and a DSL to enumerate which finders should have cached versions ' gem.summary = ' Provides a configuration for caching mechanisms and finders on ActiveRemote models' - gem.homepage = '' + gem.homepage = 'https://github.com/mxenabled/active_remote-cached' gem.required_ruby_version = '>= 2.6' gem.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR) @@ -30,4 +30,8 @@ Gem::Specification.new do |gem| gem.add_development_dependency 'rake' gem.add_development_dependency 'rspec', '>= 3.0' gem.add_development_dependency 'rubocop' + gem.add_development_dependency 'base64' + gem.add_development_dependency 'bigdecimal' + gem.add_development_dependency 'mutex_m' + gem.add_development_dependency 'ostruct' end diff --git a/lib/active_remote/cached.rb b/lib/active_remote/cached.rb index 178222b..7ef682e 100644 --- a/lib/active_remote/cached.rb +++ b/lib/active_remote/cached.rb @@ -291,7 +291,7 @@ def _define_cached_find_method(method_name, *method_arguments, cached_finder_opt sorted_method_args = method_arguments.sort.join(',') cached_methods << method_name - expanded_search_args = '' + expanded_search_args = String.new method_arguments.each do |method_argument| expanded_search_args << ":#{method_argument} => #{method_argument}," end @@ -336,7 +336,7 @@ def _define_cached_search_method(method_name, *method_arguments, cached_finder_o sorted_method_args = method_arguments.sort.join(',') cached_methods << method_name - expanded_search_args = '' + expanded_search_args = String.new method_arguments.each do |method_argument| expanded_search_args << ":#{method_argument} => #{method_argument}," end @@ -385,7 +385,7 @@ def _define_cached_search_bang_method(method_name, *method_arguments, cached_fin sorted_method_args = method_arguments.sort.join(',') cached_methods << method_name - expanded_search_args = '' + expanded_search_args = String.new method_arguments.each do |method_argument| expanded_search_args << ":#{method_argument} => #{method_argument}," end diff --git a/lib/active_remote/cached/argument_keys.rb b/lib/active_remote/cached/argument_keys.rb index a669042..d0885c7 100644 --- a/lib/active_remote/cached/argument_keys.rb +++ b/lib/active_remote/cached/argument_keys.rb @@ -23,7 +23,7 @@ class ArgumentKeys def initialize(*arguments, options) @options = options @arguments = arguments.flatten.compact - @argument_string = '' + @argument_string = String.new @arguments.each do |argument| @argument_string << argument.to_s diff --git a/lib/active_remote/cached/version.rb b/lib/active_remote/cached/version.rb index e029360..3849c5e 100644 --- a/lib/active_remote/cached/version.rb +++ b/lib/active_remote/cached/version.rb @@ -2,6 +2,6 @@ module ActiveRemote module Cached - VERSION = '1.1.1' + VERSION = '1.1.2' end end