Skip to content

Different schema classes are generated per reference of the same data class #270

Description

@jmgoncalves
from dataclasses import dataclass
import desert

@dataclass
class A:
    some_string: str

@dataclass
class B:
    prop_one: A
    prop_two: A

if __name__ == "__main__":
    schema = desert.schema_class(B)()
    prop_one_schema = schema.fields["prop_one"].schema
    prop_two_schema = schema.fields["prop_two"].schema
    print(isinstance(prop_one_schema, prop_one_schema.__class__)) # True
    print(isinstance(prop_one_schema, prop_two_schema.__class__)) # False
    print(isinstance(prop_two_schema, prop_one_schema.__class__)) # False
    print(isinstance(prop_two_schema, prop_two_schema.__class__)) # True

For the same class A there are as many schema classes as there are properties of type A.

This is inefficient (uses up more memory than needed) and can cause problems with other libraries, such as https://github.com/marshmallow-code/apispec which uses the schema class and modifiers to determine schema equality.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions