From a7b041dfb8c69becb6772aa8fcd21c2ad032b314 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sat, 15 Aug 2026 16:27:53 +0000
Subject: [PATCH] fix: repair cross-package test and type failures in monorepo
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- bunfig.toml: use `preload` instead of the ignored `environment` key so
  the happy-dom DOM environment registers for bare `bun test`
- tsconfig.json: add `bun-types` so `bun:test` imports type-check
- apps/web/src/lib/api.ts: follow the useThrottle→useDebounce rename at
  both the import and the useSearchDebounce re-export; merge duplicate import
- Button: apply aria-label to the button, with an icon-only fallback and a
  dev-only warning (guarded against a missing `process` global)
- date.ts: strip the leading zero from the en-AU day part so formatDate
  returns 1/03/2024; correct the stale MM/DD/YYYY comment
- DataTable: use a functional setState for the sort toggle to harden
  against React 18 batching; correct the stale-closure comment
---
 apps/web/src/lib/api.ts                       | 13 ++------
 bunfig.toml                                   |  2 +-
 packages/ui/src/components/Button/Button.tsx  | 31 +++++++++++++------
 .../ui/src/components/DataTable/DataTable.tsx | 16 +++++-----
 packages/utils/src/format/date.ts             | 26 +++++++++-------
 tsconfig.json                                 |  1 +
 6 files changed, 49 insertions(+), 40 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..8a635e5 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..0b64f7c 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..f9685dc 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,14 +17,14 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must carry an `aria-label`
+ * to expose an accessible name to assistive technology (WCAG 2.2 SC 4.1.2
+ * Name, Role, Value). When `iconOnly` is set without a label we fall back to a
+ * generic non-empty name so the control is never anonymous, and warn in
+ * development so the omission is fixed at the call site.
  */
+const FALLBACK_ICON_LABEL = "Button"
+
 export function Button({
   children,
   icon,
@@ -34,13 +34,26 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (
+    typeof process !== "undefined" &&
+    process.env.NODE_ENV !== "production" &&
+    iconOnly &&
+    !ariaLabel
+  ) {
+    console.warn(
+      "Button: `iconOnly` buttons require an `aria-label` to provide an accessible " +
+        `name (WCAG 2.2 SC 4.1.2). Falling back to "${FALLBACK_ICON_LABEL}".`,
+    )
+  }
+
+  const accessibleLabel = ariaLabel ?? (iconOnly ? FALLBACK_ICON_LABEL : undefined)
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..7f4341e 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -16,22 +16,20 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Clicking a sortable column header sorts by that column ascending; clicking
+ * the active column again toggles the direction. The toggle uses the functional
+ * form of setState (`setSortDir(prev => ...)`) so it always derives the next
+ * direction from the current value rather than from the `sortDir` captured in
+ * the handler's closure — this stays correct if several clicks are batched into
+ * one render.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..849e23d 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,25 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
+ * `formatDate` renders Australian day-first dates as D/MM/YYYY — the day is
+ * unpadded, the month is zero-padded and the year is four digits
+ * (e.g. 1/03/2024, 15/06/2024).
  *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * The `en-AU` locale already orders the fields day-month-year regardless of the
+ * order the options are declared in, so ordering is left to the locale. We
+ * request 2-digit parts and then strip the leading zero from the DAY part only,
+ * via `formatToParts`, which keeps the locale's own separators intact.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
+  const parts = new Intl.DateTimeFormat("en-AU", {
+    day: "2-digit",
+    month: "2-digit",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+
+  return parts
+    .map((part) => (part.type === "day" ? part.value.replace(/^0/, "") : part.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]