I found a missing implementation in the following code:
https://github.com/roborescue/adf-core-java/blob/dc74429e5b09ba2f2a08e92e9a52478e1fbeff0a/src/main/java/adf/impl/extaction/DefaultExtActionFireRescue.java#L127
The needRest() method determines whether a REST command should be executed, but the result of this test is not used afterward.
I'm planning to fix this soon to align with the existing logic. In addition, most ExtActions contain the same logic. Therefore, I'm considering refactoring them into utility methods.
If you have any suggestions, please reply to this issue.
I found a missing implementation in the following code:
https://github.com/roborescue/adf-core-java/blob/dc74429e5b09ba2f2a08e92e9a52478e1fbeff0a/src/main/java/adf/impl/extaction/DefaultExtActionFireRescue.java#L127
The
needRest()method determines whether aRESTcommand should be executed, but the result of this test is not used afterward.I'm planning to fix this soon to align with the existing logic. In addition, most
ExtActions contain the same logic. Therefore, I'm considering refactoring them into utility methods.If you have any suggestions, please reply to this issue.