Time.rfc3339 error message says "invalid xmlschema format"

[yahonda]

Time.rfc3339 on master (tested at b126827) reports an invalid string as an invalid xmlschema.

Steps to reproduce

require "bundler/inline"

gemfile(true) do
  source "https://rubygems.org"
  gem "time", github: "ruby/time"
end

require "time"

Time.rfc3339("foobar")

Expected behavior

The ArgumentError message names RFC 3339, the format Time.rfc3339 is documented to parse.

Actual behavior

lib/time.rb:677:in 'Time._xmlschema': invalid xmlschema format: "foobar" (ArgumentError)

The message is hardcoded in the _xmlschema helper the pattern is handed to:

time/lib/time.rb

Line 677 in b126827

raise ArgumentError.new("invalid xmlschema format: #{time.inspect}")

References

• Time.iso8601 raises the same message, which is consistent with its documentation: iso8601 is an explicit alias of xmlschema (

  time/lib/time.rb

  Line 639 in b126827

  alias iso8601 xmlschema

  )
• Time.rfc3339 is a separate method documented as parsing RFC 3339 (

  time/lib/time.rb

  Line 657 in b126827

  def rfc3339(time)

  ), so the format name in the message does not match what was parsed

[jeremyevans]

Thank you for the report. Note that I already submitted #79 to fix this.

[yahonda]

Thanks. I'm closing this issue and following #79 .