Update to support RestSharp v110.2.0

[ncosentino]

It seems as though there have been breaking API changes in RestSharp since this was last released.

When going into this constructor for a RedditClient:
at Reddit.RedditClient..ctor(String appId, String refreshToken, String appSecret, String accessToken, String userAgent)

It seems as though there used to be a constructor for a RestSharp client with a single parameter:
Method not found: 'Void RestSharp.RestClient..ctor(System.String)'.

I'm now torn because if I want to use this package, I need to downgrade RestSharp to some older version with high security vulnerabilities and break everything else in my app. Or... I need to go port all of the code in this library to meet the new RestSharp API.

[sirkris]

I'm really sorry to hear that. I tried to update RestSharp awhile back but wound up being blocked due to an apparent bug in the newer version. I posted about it at length on another thread:

#143

I opened a bug on RestSharp's issue tracker but it never got a response. Eventually one of their bots auto-closed the ticket as a "Won't Fix" without further explanation. That was when I said "fuck it" and decided to just keep the existing version for the time-being.

It is theoretically possible that they've since fixed that bug in an even newer release, though I honestly don't know as I haven't been following that project. The last time I checked on this was back in June.

I honestly haven't been doing much with this since Reddit started looking for ways to paywall parts of the API and the whole IPO fiasco. But they've also now instituted a lifetime limit of 3 apps per Reddit user, which effectively makes it impossible for me to create any new apps for testing. I asked the admins to fix that or at least remove the limit from my account so I can resume testing, but last I checked I hadn't received a response yet.

That said, I'm still willing to do hotfixes for stuff like this. My time is limited right now but if you were to do a pull request with the library upgrade and all tests still pass, then I'll be happy to put it out as a hotfix and add your name to the list of contributors. Otherwise, I'm afraid this is one of those "I'll get to it when I get to it" kinda things, so I'd say your best bet if you want this done promptly would be to do a pull request yourself and then I'll take it from there. :)

[ncosentino]

I'm most of the way through updating it, so it might not be so bad if the tests pass. Couple of questions:

1. Do I need to update something to run the tests locally? Like for my own app to test with? I'm not yet able to compile, but when I can, this will be the next thing to go muck around with.

2. The constructor pathway for the Request / BaseModel taking in a ref RestClient is extremely cumbersome. It's the last thing (for now) that I need to tackle since the UserAgent cannot be set this way:

        public Request(string appId, string appSecret, string refreshToken, string accessToken, ref RestClient restClient, string deviceId = null, string userAgent = null)
        {
            AppId = appId;
            AppSecret = appSecret;
            AccessToken = accessToken;
            RefreshToken = refreshToken;
            RestClient = restClient;
            DeviceId = deviceId;

            string version = "Reddit.NET v" + GetVersion();
            if (!string.IsNullOrWhiteSpace(userAgent))
            {
                version = userAgent + " (via " + version + ")";
            }

            // FIXME: can't do this -> it's all immutable
            RestClient.Options.UserAgent = version;

            Requests = new List<DateTime>();
        }

[sirkris]

This is the file you want to modify for getting the tests to work:

https://github.com/sirkris/Reddit.NET/blob/master/src/Reddit.NETTests/Reddit.NETTestsData.xml

As for the user-agent issue, feel free to make whatever change is necessary to get that working. So long as we're sending that same User-Agent in our request headers somehow then we should be good.

[Mike-E-angelo]

I just ran into this very issue and am glad to see it's being tracked here. I recently did a major upgrade with my solution which included implementing Central Package Management and consolidating my projects from about 150 to 40. 😬 Somewhere in there this ended up getting this issue to occur. I still have to investigate further, but I am interested on how this occurred when 110.2.0 was released last April. I have had this version for sure during this time so I am unclear how I didn't run into this issue before then.

[Mike-E-angelo]

So it looks like what happened was I had two projects:

Feature.A - Reddit.NET
Feature.B - RestSharp 110.2.0

Now they are rolled up into one project:

Feature

• A
• B

Since they are both sharing the same dependencies now they are both forced on 110.2.0, leading to the error. 💥

I am a little concerned that this project hasn't had an update for nearly two years now. 😟 It would be nice to get this addressed. I have disabled announcements to Reddit in the meantime.

[Mike-E-angelo]

I managed to find a way to get Reddit.NET+old RestSharp on its own app domain altogether and therefore working again

[Mike-E-angelo]

Getting these warnings now on the latest Visual Studio Preview:

Package 'RestSharp' 106.6.9 has a known high severity vulnerability, https://github.com/advisories/GHSA-9pq7-rcxv-47vq

😞

[Mike-E-angelo]

Hi @sirkris are you able to update the version to 106.12.0 by chance? That is still the same major version as 106.6.9 (106) so it shouldn't introduce breaking changes while adding security to the library. Thank you for any consideration. 🙏

[Mike-E-angelo]

Nevermind! We can do this locally.

<ItemGroup>
		<PackageReference Include="Reddit" />
		<PackageReference Include="RestSharp">
			<OverrideVersion>106.12.0</OverrideVersion>
		</PackageReference>
	</ItemGroup>

Back to my Neo impersonation...

[sirkris]

I haven't tried to update RestSharp since this debacle: #143

If somebody would like to do the update as a pull request (making sure ALL tests still pass!), then I'll be happy to merge it in and put out a hotfix. That would be faster as I don't know when I'll have time to actually dig into this again.

[Mike-E-angelo]

I haven't tried to update RestSharp since this debacle: #143

Indeed I tried poking through that @sirkris and was bummed to see an issue closed without discussion. 😭💥 I for one can use the above workaround for now, so no worries about a PR for the moment. 👍