From b0361f3464ccca0134189282aa1de7549c40623c Mon Sep 17 00:00:00 2001 From: CodeGraph Test Date: Thu, 1 Oct 2026 14:07:13 +0800 Subject: [PATCH] ci: leave release-please's scaffold.json bump out of oxfmt The release PR for 0.51.0 failed `make check`: release-please's JSON extra-file updater rewrites the whole of `.github/scaffold.json` to bump `placeholders.CURRENT_VERSION`, expanding the inline `addons` array, and oxfmt rejects the expanded form. Merged as is, the same check would fail main CI on the release commit and with it the release workflow's exact-SHA CI gate. The file joins the release-please-owned entries in `.oxfmtignore`, and is committed in the shape release-please writes, so a release PR now changes only the version line. --- .github/scaffold.json | 4 +++- .oxfmtignore | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/scaffold.json b/.github/scaffold.json index c227d16..a78d5d5 100644 --- a/.github/scaffold.json +++ b/.github/scaffold.json @@ -1,6 +1,8 @@ { "profile": "rust", - "addons": ["codecov"], + "addons": [ + "codecov" + ], "placeholders": { "BINARY": "codegraph", "CRATE": "codegraph-rs", diff --git a/.oxfmtignore b/.oxfmtignore index c7a9319..a659ed9 100644 --- a/.oxfmtignore +++ b/.oxfmtignore @@ -1,10 +1,13 @@ # oxfmt ignore — files oxfmt must NOT touch. # # Release-please owns changelog and manifest bytes; the general repository -# formatter must not rewrite them between release PR updates. +# formatter must not rewrite them between release PR updates. Its JSON +# extra-file updater rewrites the whole of `.github/scaffold.json` (an inline +# array comes back expanded), so oxfmt must leave that file to it as well. changelog/ .release-please-manifest.json release-please-config.json +.github/scaffold.json # Frozen/hash-addressed upstream-sync provenance. These bytes are reviewed and # verified by SHA rather than rewritten by the general Markdown formatter.