test(uat): SYSTEM priv string tracks PHY_IO in VMS_PRV_M_ENFORCED (vms-3a7) - #1033
Open
baron-3dl wants to merge 1 commit into
Open
test(uat): SYSTEM priv string tracks PHY_IO in VMS_PRV_M_ENFORCED (vms-3a7)#1033baron-3dl wants to merge 1 commit into
baron-3dl wants to merge 1 commit into
Conversation
…s-3a7) #1009 (vms-7eb) added VMS_PRV_M_PHY_IO (bit 22) to VMS_PRV_M_ENFORCED and updated the C-level oracle test (tests/qemu/test_syssvc_ident.c:1937) to expect the booted runtime's SYSTEM identity as ...WORLD,MOUNT,PHY_IO" but left the UAT script's IDENT_CURPRIV/AUTHPRIV literals stale at ...WORLD,MOUNT" The UAT literal is DERIVED from that mask (its own comment says so and that it must be updated whenever VMS_PRV_M_ENFORCED changes); the drift red the "VMS User Acceptance Test" leg on main deterministically. Align the two UAT literals to the shipped, oracle-asserted privilege set and extend the derivation comment to record PHY_IO's addition (bit 22, after MOUNT), matching how it already tracks MOUNT (bit 17, vms-651). Tightens the assertion; nothing weakened. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PhM3QcmFEY3p8YNnHGaYwP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a deterministic main-red: stale UAT privilege string
The VMS User Acceptance Test leg is red on
main(and was already red on the parent of the current tip — this is not the db20-a/160c5f18cluster commit, which is exonerated).Root cause
#1009 (
97f3cc5a, vms-7eb — "executive L2 AF_PACKET datalink + PHY_IO gate") addedVMS_PRV_M_PHY_IO(bit 22) toVMS_PRV_M_ENFORCED(src/kernel/vms_ioctl.h:290-293), so the booted SYSTEM identity now renders as…WORLD,MOUNT,PHY_IO". That commit updated the C-level oracle test (tests/qemu/test_syssvc_ident.c:1937, which passes) but left the UAT script's twoIDENT_CURPRIV/IDENT_AUTHPRIVliterals stale at…WORLD,MOUNT".The UAT literal is derived from that mask — its own comment says so and says to update it whenever
VMS_PRV_M_ENFORCEDchanges. This just does that.Change
,PHY_IOto both UAT literals (tests/uat/vms_session_qemu.sh:980-981), matching the ascending-bit-position order the C oracle already asserts (PHY_IO bit 22, after MOUNT bit 17).Tightens the assertion to the shipped, oracle-asserted privilege set; nothing weakened.
bash -nclean. No other staleWORLD,MOUNT"occurrences remain in the tree.Tracks vms-3a7.
🤖 Generated with Claude Code