fix: print the telemetry notice before any event is sent - #2
Merged
Merged
Conversation
The notice now runs in beginUsage, ahead of the command, and prints in every output mode until the user saves a preference. Redirected, --json, --plain, and --quiet sessions were never informed before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1 from the telemetry collector security audit.
beginUsage, before the command runs and before any event leaves the machine.--json,--plain,--quiet, redirected output) until the user saves a preference withdatatf telemetry enableordisable. Previously a--jsonuser with no saved preference was never informed while events were still sent.Test plan
make checkTestTelemetryNoticeUntilPreferenceSavedcovers all four output modes, a failed command, and silence after a saved preference