fix: neutralize untrusted workspace strings and redact credential secrets - #4
Merged
Merged
Conversation
jwmoss
force-pushed
the
fix/harden-untrusted-output
branch
from
September 12, 2026 01:12
e86eb51 to
bd74570
Compare
…rets Sanitize progress lines, the auth status table, and HCL comment text; extend terminalText to format and line separator characters; redact storage credential secret fields from inventory output; cap grant pagination; and allowlist the workspace_error and render_error telemetry categories.
jwmoss
force-pushed
the
fix/harden-untrusted-output
branch
from
September 12, 2026 01:12
bd74570 to
3fb2079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups from the 1.0.3 Go code security audit. No findings were critical or high; these close the medium and low items that are cheap and self-contained.
progress()sanitizes every argument withterminalTextat the sink, so a warehouse or service principal named with escape sequences cannot rewrite the operator's terminal.terminalTextalso escapes Unicode format characters (bidi overrides, isolates) and U+2028/2029.auth statustable cells go throughterminalText.writeCommentsin the HCL renderer, the only path that bypasseshclwrite, strips line breaks.client_secretandsecret_access_keybefore serialization. UC redacts these today; DataTF no longer relies on that.workspace_errorandrender_errorjoin the telemetry error-code allowlist, with a test that every CLI code round-trips.Test plan
make check(golden files unchanged)