fix: validate instance-pool module inputs - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit input guards and negative tests for the instance-pool module. Reject malformed inputs before API operations while preserving valid DataTF exports and Terraform resource addresses. Preserve zero as unlimited pool capacity. Preserve null inputs where the provider supplies defaults. Document the access-management boundaries.
Validation: new regression tests fail before the fix; Terraform mock tests pass with Databricks providers 1.128.0 and 1.130.0; fmt, validate, terraform-docs, and TFLint pass. DataTF's local candidate integration passes both layouts and both scopes with import-only and clean post-import plans.
Terraform's minimum remains 1.5. These checks do not certify live permission visibility. Release this module before updating the workspace pattern and DataTF tested version pins.
Tracking PR: 536tech/datatf#5