Skip to content

Increase GNU Radio World embed height via shared CSS override - #177

Merged
777arc merged 2 commits into
masterfrom
copilot/make-grw-embeds-taller
Sep 22, 2026
Merged

777arc merged 2 commits into
masterfrom
copilot/make-grw-embeds-taller

Conversation

Copilot AI commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

GNU Radio World embeds were rendering shorter than desired across the book. This updates the shared iframe sizing override so all GRW embeds render 50% taller without editing each chapter embed individually.

  • What changed

    • Updated the shared iframe[src*="gnuradioworld.com"] rule in _static/custom.css
    • Increased the enforced embed height by adjusting:
      • aspect ratio from 21/9 to 14/9
      • minimum height from 345px to 518px
      • wide-screen height cap from 640px to 960px
  • Why this shape

    • Keeps embed sizing centralized in one place
    • Applies consistently to homepage and chapter embeds, including those with inline iframe styles
  • Resulting override

    iframe[src*="gnuradioworld.com"] {
      aspect-ratio: 14 / 9 !important;
      min-height: 518px !important;
      max-height: min(90vh, 960px);
    }

Copilot AI linked an issue Sep 22, 2026 that may be closed by this pull request
Co-authored-by: 777arc <5722532+777arc@users.noreply.github.com>
Copilot AI changed the title [WIP] Update GNU Radio World embeds to be 50% taller Increase GNU Radio World embed height via shared CSS override Sep 22, 2026
Copilot AI requested a review from 777arc September 22, 2026 13:08
@777arc
777arc marked this pull request as ready for review September 22, 2026 13:24
Copilot AI lite review requested due to automatic review settings September 22, 2026 13:24
@777arc
777arc merged commit 04e87d5 into master Sep 22, 2026
@777arc
777arc deleted the copilot/make-grw-embeds-taller branch September 22, 2026 13:25
Copilot stopped reviewing on behalf of 777arc due to an error September 22, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Copilot review overview

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Updates the CSS for embedded GNU Radio World iframes to make them taller and to override inline sizing styles consistently across the book.

Changes:

  • Replaced the prior “cap height only” approach with explicit aspect-ratio + min-height overrides (using !important to beat inline styles).
  • Increased the wide-screen max-height cap by ~50% (from 60vh/640px to 90vh/960px).
  • Updated the explanatory comment to reflect the new sizing strategy.
File Description
_static/​custom.css Adjusts GNU Radio World iframe sizing (aspect ratio, min-height, and max-height caps) and updates related documentation comment.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread _static/custom.css
iframe[src*="gnuradioworld.com"] {
max-height: min(60vh, 640px);
aspect-ratio: 14 / 9 !important;
min-height: 518px !important;
Comment thread _static/custom.css
max-height: min(60vh, 640px);
aspect-ratio: 14 / 9 !important;
min-height: 518px !important;
max-height: min(90vh, 960px);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make GRW embeds taller

3 participants