Increase GNU Radio World embed height via shared CSS override - #177
Merged
Merged
Conversation
Closed
Co-authored-by: 777arc <5722532+777arc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update GNU Radio World embeds to be 50% taller
Increase GNU Radio World embed height via shared CSS override
Sep 22, 2026
777arc
marked this pull request as ready for review
September 22, 2026 13:24
Copilot stopped reviewing on behalf of
777arc due to an error
September 22, 2026 13:25
There was a problem hiding this comment.
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates the CSS for embedded GNU Radio World iframes to make them taller and to override inline sizing styles consistently across the book.
Changes:
- Replaced the prior “cap height only” approach with explicit
aspect-ratio+min-heightoverrides (using!importantto beat inline styles). - Increased the wide-screen
max-heightcap by ~50% (from60vh/640pxto90vh/960px). - Updated the explanatory comment to reflect the new sizing strategy.
| File | Description |
|---|---|
_static/custom.css |
Adjusts GNU Radio World iframe sizing (aspect ratio, min-height, and max-height caps) and updates related documentation comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| iframe[src*="gnuradioworld.com"] { | ||
| max-height: min(60vh, 640px); | ||
| aspect-ratio: 14 / 9 !important; | ||
| min-height: 518px !important; |
| max-height: min(60vh, 640px); | ||
| aspect-ratio: 14 / 9 !important; | ||
| min-height: 518px !important; | ||
| max-height: min(90vh, 960px); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


GNU Radio World embeds were rendering shorter than desired across the book. This updates the shared iframe sizing override so all GRW embeds render 50% taller without editing each chapter embed individually.
What changed
iframe[src*="gnuradioworld.com"]rule in_static/custom.css21/9to14/9345pxto518px640pxto960pxWhy this shape
Resulting override