Skip to content

updating demo notebook - #72

Open
mahaalbashir wants to merge 5 commits into
mainfrom
update_demo_notebbok
Open

updating demo notebook#72
mahaalbashir wants to merge 5 commits into
mainfrom
update_demo_notebbok

Conversation

@mahaalbashir

Copy link
Copy Markdown
Collaborator

In this PR:

  • updated the demo notebook
  • Made some small changes to the documentation keeping in mind how things will display in sacro-tools
  • updated the NEWS.md file with the changes made so far.

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6fcdd74) to head (5e4259c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #72   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          281       281           
=========================================
  Hits           281       281           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread inst/notebooks/acro_demo_2026.R Outdated
#' *mode*.
#' - you can also pass a list of aggregation functions e.g.
#' `aggfunc <-list("mean","median")`
#' - NB we have recently had reports of instability when automatically suppressing

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is true. Maybe say, it should be fixed in versions 1.0 and above which implement suppression differently

@jim-smith jim-smith left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of really minor tweaks please

mahaalbashir and others added 3 commits August 12, 2026 10:04
Co-authored-by: Jim-smith <jim-smith@users.noreply.github.com>
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
Signed-off-by: mahaalbashir <mahaalialbashir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants