Fix VAE-aligned chunking in full-song inference - #5
Open
zonnart17-collab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix cumulative timing drift and padded output tails in both SonicMaster full-song inference paths.
fullsong_chunking.py;infer_single.pyandinference_fullsong.py;infer_single.pyno longer exposes--fs,--chunk_duration, or--overlap_duration. Input audio is resampled to the published checkpoint sample rate of 44.1 kHz.Background
The previous 30-second waveform chunk contained 1,323,000 samples at 44.1 kHz, but the Oobleck VAE encodes it to 645 frames and decodes those frames to 1,320,960 samples.
That 2,040-sample discrepancy accumulates at every stitched chunk boundary. The previous nominal 10-second overlap also used 441,000 samples instead of the VAE-native 215 × 2048 = 440,320 samples.
The corrected geometry is:
Validation
py_compile: passedtests/test_fullsong_chunking.py: 11 tests passedNo changes are made to
model.py, model configuration, training, preencoding, latent batch inference, dataset generation, or evaluation code.