Make npm the default install path, and actually test the published artifact - #3
Merged
Merged
Conversation
…he default 0.1.1 is on the registry, so the installation notice and the release-tarball detour come out and npx becomes the documented path again. The walkthrough had a real bug that only appeared once npm was the spec. It ran `npx --yes <package>`, and npx resolves a LOCAL package first. Run from inside this repository, whose package.json declares this very bin, npx tried the working tree and died with "command not found". The README tells you to run it from the clone, so that was the normal case, and it silently defeated the one property the walkthrough exists to guarantee: that it exercises what a developer installs. It now installs the spec into a throwaway prefix and runs that binary directly. The guarantee is real rather than dependent on npx's resolution order. Verified against the published npm artifact from inside the clone: server reports 0.1.1, untampered returns requires_approval with the correct violation, tampered is rejected. The 0.1.0 pin warning stays. That version is still on the registry and still has the first-use defect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.1.1 is live on npm, so the installation notice and release-tarball detour come out.
The bug this surfaced
The walkthrough ran
npx --yes <package>. npx resolves a local package first. Run from inside this repository, whosepackage.jsondeclares this very bin, npx tried the working tree and failed withcommand not found. The README tells you to run it from the clone, so that was the normal case, and it silently defeated the one property the walkthrough exists to guarantee.It now installs the spec into a throwaway prefix and runs that binary directly.
Verified against the published npm artifact
The 0.1.0 pin warning stays; that version is still on the registry with the first-use defect.
🤖 Generated with Claude Code