fix(unity-bootstrap-theme): form field validation - #1776
Open
scott-williams-az wants to merge 1 commit into
Open
fix(unity-bootstrap-theme): form field validation#1776scott-williams-az wants to merge 1 commit into
scott-williams-az wants to merge 1 commit into
Conversation
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1776/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bootstrap client side validation in the unity-bootstrap-theme
Solution
Update Css to allow invalid and valid elements visibility based on submission state and field valid state.
Updated Storybook example with a client side working example
Reduced the amount of stories/repeated code by adding storybook controls for background variations
Moving these form fields still need to migrate to unity-react-core, but I feel this is a bigger effort for fixing this bug
Links