maxdiff: show parameter properties in parameter summary - #64
Merged
Conversation
MattijsKneppers
force-pushed
the
mkp-maxdiff-show-param-properties
branch
2 times, most recently
from
February 27, 2026 11:27
c1e5974 to
a0ba14b
Compare
MattijsKneppers
force-pushed
the
mkp-maxdiff-show-param-properties
branch
from
June 23, 2026 07:02
a0ba14b to
822b72c
Compare
- rename some variables in patch printer - remove unused indent - simplify get_param_properties_from_ids_recursive loop
MattijsKneppers
force-pushed
the
mkp-maxdiff-show-param-properties
branch
from
August 28, 2026 09:51
822b72c to
3c6af12
Compare
added 3 commits
August 28, 2026 11:52
This makes it much easier to spot regressions in the parameter space when refactoring devices
MattijsKneppers
force-pushed
the
mkp-maxdiff-show-param-properties
branch
from
August 28, 2026 09:52
3c6af12 to
ab8ec54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature makes changes in the parameter space more obvious.
When changing a device that was published, the properties of existing parameters should typically not change, so that Live sets created with earlier versions of the device will still work. This change will make it easier to spot any differences in the parameter space of devices.
For unfrozen devices, it is not always possible to resolve all parameter information: when a parameter lives in an abstraction, we can't know which file to parse since the dependencies used depend on Max' global search path.
That is why this PR also adds the parameter summary to srozen devices, which have all their dependencies bundled within the device file. To guarantee that a device's parameter space hasn't changed, you can now check the diff of the frozen version of the device.