fix(build): Correctly serialize CUDA build in testrender - #2157
Merged
lgritz merged 1 commit intoAug 30, 2026
Merged
Conversation
When building with CUDA / OptiX, src/testrender/CMakeLists.txt was not specifying a dependency of testrender on testrender_ptx, allowing GNU Make to run these two sets of instructions as parallel jobs. When building on multiple cores, this could result in llvm crashing when the testrender build steps would try to access files still being build by the testrender_ptx build steps. This addresses [Issue 2156](AcademySoftwareFoundation#2156) and is the same fix which was previously applied to testshade in [PR 2012](AcademySoftwareFoundation#2012). Assisted-by: Claude/Sonnet 5 Signed-off-by: Jean-Francois Panisset <panisset@gmail.com>
Collaborator
|
I think the magic words are: or "Closes", in order to make GitHub understand that when a PR is merged, the linked Issue should be closed as a result. Any other rewordings, no matter how obvious to humans, are not understood by GitHub to indicate that the issue is really fixed/closed by the PR, merely that it references it. I'm not sure if it will work for me to edit it it, since I'm not the author. Can you edit the PR description to fix the wording? Thanks. |
Contributor
Author
|
I think that worked, the issue is now showing that it will be closed by this PR. Slightly confusing that issue and PR count are basically the same! |
lgritz
merged commit Aug 30, 2026
b81eb60
into
AcademySoftwareFoundation:main
24 of 25 checks passed
lgritz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with CUDA / OptiX, src/testrender/CMakeLists.txt was not specifying a dependency of testrender on testrender_ptx, allowing GNU Make to run these two sets of instructions as parallel jobs. When building on multiple cores, this could result in llvm crashing when the testrender build steps would try to access files still being build by the testrender_ptx build steps.
Fixes #2156 and is the same fix which was previously applied to testshade in PR 2012.
Assisted-by: Claude/Sonnet 5