fix: Honor chapter point limits - #1491
Merged
Merged
Conversation
github-actions
Bot
added
Area: JSON
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 28 files
Confidence score: 5/5
- In
scripts/scr_chapter_new/scr_chapter_new.gml, duplicated chapter-points validation and flooring logic could drift between the normal and custom paths over time; extract the shared calculation into a helper while preserving their distinct fallback values.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/scr_chapter_new/scr_chapter_new.gml">
<violation number="1" location="scripts/scr_chapter_new/scr_chapter_new.gml:249">
P2: Custom agent: **Code Quality Review**
The normal and custom chapter paths duplicate the same chapter-points validation and flooring logic, differing only in the fallback value. Extract this calculation into a helper that accepts the fallback so future validation changes stay consistent.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes chapter creation to respect each chapter's defined point limit instead of using hardcoded values. Premade chapters now use their
pointsfield (all set to 250), while custom chapters keep a 100-point default. Also saves the active point limit when a chapter is saved, so it persists.Written for commit 25e1bda. Summary will update on new commits.