fix: harden bounded bulk cold reads by khaliqgant · Pull Request #466 · AgentWorkforce/relayfile

khaliqgant · 2026-09-05T19:58:19Z

Repairs review findings for #465 / #464.

inherited ACL checks happen before path probes
bulk response validates content/contentType presence and custom-client result counts
declared >32 MiB files use point reads
batches are bounded by exact marshaled JSON request size
streaming response reads refresh bootstrap watchdog progress
OpenAPI documents UTF-8 path, aggregate, and 64 KiB request constraints

Evidence: go test ./..., go test -race ./internal/mountsync ./internal/httpapi, go vet ./..., ./scripts/check-contract-surface.sh, git diff --check, and Daytona candidate qualification green.

Does not merge #465; merge remains operator-gated.

chatgpt-codex-connector · 2026-09-05T19:58:30Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-06T00:10:46.750218Z	`abcc063`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

coderabbitai · 2026-09-05T19:58:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 62ecf133-7ba0-4e4a-b414-ea1bf3940128

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-05T20:00:31Z

Relayfile Eval Review

Run: .relayfile/evals/runs/2026-09-06T00-07-42-148Z-HEAD-provider
Mode: provider
Git SHA: b067787

Human Review Cases

No reviewable human-review cases captured Relayfile output.

chatgpt-codex-connector

💡 Codex Review

relayfile/internal/mountsync/syncer.go

Lines 7346 to 7348 in cf5c0ea

    
           if isBulkReadUnsupported(err) { 
        
           	s.bulkReadUnsupported.Store(true) 
        
           	return s.readBootstrapFilesIndividually(ctx, jobs, prog)

Reuse oversized point reads during compatibility fallback

On a mixed bootstrap page containing both a declared-over-32-MiB file and a smaller file, an older server returning 501 bulk_read_unsupported reaches this branch only after the oversized pointJobs have already been downloaded. Falling back with the complete jobs slice downloads those large files a second time, potentially doubling substantial bootstrap bandwidth and latency; retain the completed point results and point-read only bulkJobs here.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

khaliqgant · 2026-09-05T20:04:58Z

@codex review

cubic-dev-ai

All reported issues were addressed

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

khaliqgant · 2026-09-05T20:07:40Z

Fresh review fix pushed as 163852a: 501 compatibility fallback now preserves completed oversized point reads and only point-reads current/unprocessed bulk jobs. Focused tests pass. Fresh Daytona baseline/candidate rerun is externally blocked before sandbox creation: org inventory reports 304 total CPUs against 250 maximum; no ambient sandboxes touched. Prior candidate Daytona run (sandbox ee663af5-cd7d-43e2-a234-f7b5342dc67b) passed and proved cleanup.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 163852adc0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

khaliqgant · 2026-09-05T20:10:13Z

@codex review

khaliqgant · 2026-09-05T20:10:15Z

Follow-up review fixes pushed: 1197045 wraps watchdog progress before oversized point reads, includes target ACL in precheck, and reuses computed permissions. Focused Go tests pass. Fresh full suite rerun was blocked by host ENOSPC after Daytona artifact attempts; prior CI run was green on 163852a.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1197045b85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

khaliqgant · 2026-09-05T20:42:34Z

@codex review

khaliqgant · 2026-09-05T20:43:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b40d03b11a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

khaliqgant · 2026-09-05T22:32:27Z

@codex review

khaliqgant · 2026-09-05T22:32:28Z

@cubic-dev-ai review

cubic-dev-ai · 2026-09-05T22:32:31Z

@cubic-dev-ai review

@khaliqgant I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 653c4c427f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

khaliqgant · 2026-09-05T22:36:09Z

@codex review

khaliqgant · 2026-09-05T22:36:11Z

@cubic-dev-ai review

cubic-dev-ai · 2026-09-05T22:36:15Z

@cubic-dev-ai review

@khaliqgant I have started the AI code review. It will take a few minutes to complete.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f42bb4fbbb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

khaliqgant · 2026-09-05T23:44:02Z

@codex review

khaliqgant · 2026-09-05T23:44:03Z

@cubic-dev-ai review

cubic-dev-ai · 2026-09-05T23:44:09Z

@cubic-dev-ai review

@khaliqgant I have started the AI code review. It will take a few minutes to complete.

chatgpt-codex-connector · 2026-09-05T23:48:07Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 0b80548576

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cubic-dev-ai

No issues found across 6 files

_{Re-trigger cubic}

khaliqgant · 2026-09-05T23:51:00Z

@codex review

khaliqgant · 2026-09-05T23:51:01Z

@cubic-dev-ai review

cubic-dev-ai · 2026-09-05T23:51:05Z

@cubic-dev-ai review

@khaliqgant I have started the AI code review. It will take a few minutes to complete.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14b127cb19

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cubic-dev-ai

All reported issues were addressed across 2 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

cubic-dev-ai

All reported issues were addressed across 6 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

khaliqgant · 2026-09-06T00:01:19Z

@codex review

khaliqgant · 2026-09-06T00:01:20Z

@cubic-dev-ai review

cubic-dev-ai · 2026-09-06T00:01:26Z

@cubic-dev-ai review

@khaliqgant I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 3 files (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

khaliqgant · 2026-09-06T00:05:11Z

@codex review

khaliqgant · 2026-09-06T00:05:12Z

@cubic-dev-ai review

cubic-dev-ai · 2026-09-06T00:05:15Z

@cubic-dev-ai review

@khaliqgant I have started the AI code review. It will take a few minutes to complete.

chatgpt-codex-connector · 2026-09-06T00:10:45Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: abcc0632df

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cubic-dev-ai

No issues found across 6 files

_{Re-trigger cubic}

khaliqgant · 2026-09-06T00:13:57Z

Final exact-head evidence: Relayfile 0b80548 and Cloud PR #186 49529fa5bbc33a819826dd356cd08133e84ed908 were validated locally. Relayfile full Go tests, focused/race mountsync tests, HTTP ACL regression, contract, and diff checks passed. Cloud tests passed: 58 files / 1052 tests, typecheck, and 6 targeted ACL target/ancestor tests. Clean Workerd candidate qualification was GREEN for 851 files / 454 directories / 270532608 bytes (258 MiB), manifest SHA256 905968a14268ec5e8ec38ae1d6b24749e855cac035976a87a65ef43f6612a55a; standard/concurrent/retry/unsupported-path hashes verified and cleanupVerified=true. Fresh Daytona retry created no sandbox: provider rejected creation before allocation with exact Total CPU limit exceeded. Maximum allowed: 250. Generated name relayfile-cold-mount-qual-20260905T230008Z-27553 was verified Not Found afterward; no sandbox ID or unrelated resources were deleted.

khaliqgant · 2026-09-06T00:14:14Z

Correction to the evidence note above: the exact current Relayfile PR #466 head is abcc063. All nine checks on that SHA are completed/success, including fresh Cubic; GraphQL reports 29 total review threads and zero unresolved.

khaliqgant · 2026-09-06T00:22:53Z

Fresh exact-head Daytona qualification (Relayfile abcc063 + Cloud PR #186 49529fa5bbc33a819826dd356cd08133e84ed908) is GREEN. Sandbox 5e504b9a-e2c4-40a5-9032-76982c55eeaf (relayfile-cold-mount-qual-20260906T001802Z-92930) used mount linux-amd64 artifact SHA256 573a1595f7014d85e8e23bf3df214da0205dbd8cf31156f5bdfebef4d959f007 and cloud npm-pack SHA256 04a7e9365cda1b702fc22aac96012e24bb8df33b0d6844e7b1a812d5c68db1af. Fixture exactly 851 files / 454 directories / 270532608 bytes, manifest SHA256 905968a14268ec5e8ec38ae1d6b24749e855cac035976a87a65ef43f6612a55a. Initial standard: 32 requests (28 bulk, 0 point), all 3 mount hashes verified; wall 15780ms, CPU 7000ms. Suite: wall 150492ms, CPU 77000ms, peak RSS 1791627264 bytes. Injected 429/503/reset retries all succeeded with verified hashes; malformed response was expected-failure; 501 unsupported fallback succeeded with 851 point reads and verified hashes. Exact cleanup verified: daytona info returned Not Found for the ID, inventory (154 entries, no matching ID/name) had no target, and local build scratch cleanup was verified.

fix(mount): harden bounded bulk cold reads

cf5c0ea

khaliqgant mentioned this pull request Sep 5, 2026

feat(mount): batch bounded cold-start reads #465

Merged

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/httpapi/server.go Outdated

fix(mount): avoid duplicate fallback reads

163852a

cubic-dev-ai Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go

Comment thread internal/httpapi/server.go Outdated

Comment thread internal/mountsync/syncer.go Outdated

Comment thread internal/httpapi/server.go Outdated

fix: complete ACL and fallback review hardening

1197045

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go Outdated

Comment thread internal/mountsync/syncer.go Outdated

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go Outdated

fix(mount): bound oversized bootstrap reads

b40d03b

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go Outdated

cubic-dev-ai Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go Outdated

Comment thread internal/mountsync/syncer.go Outdated

fix(mount): preserve cold-read ordering and bounds

653c4c4

cubic-dev-ai Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/bulk_read_test.go Outdated

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go

test(mount): synchronize point-read fixture errors

14cc8ed

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go

refactor(httpapi): share ACL permission extraction

0b80548

cubic-dev-ai Bot reviewed Sep 5, 2026

View reviewed changes

fix(mount): split oversized bulk response retries

14b127c

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go

cubic-dev-ai Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go

cubic-dev-ai Bot reviewed Sep 5, 2026

View reviewed changes

Comment thread internal/mountsync/syncer.go

Comment thread internal/mountsync/syncer.go

Comment thread internal/mountsync/syncer.go

fix: bound response reads and document 413 fallback

8f61449

cubic-dev-ai Bot reviewed Sep 6, 2026

View reviewed changes

Comment thread internal/mountsync/http_client_test.go

test(mount): cover fragmented response limits

abcc063

cubic-dev-ai Bot reviewed Sep 6, 2026

View reviewed changes

khaliqgant merged commit 3700360 into feat/cold-mount-bulk-read-464 Sep 6, 2026
11 checks passed

khaliqgant deleted the feat/cold-mount-bulk-read-464-repair branch September 6, 2026 00:23

	if isBulkReadUnsupported(err) {
	s.bulkReadUnsupported.Store(true)
	return s.readBootstrapFilesIndividually(ctx, jobs, prog)

Uh oh!

Conversation

khaliqgant commented Sep 5, 2026 • edited by cubic-dev-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

coderabbitai Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relayfile Eval Review

Human Review Cases

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

khaliqgant commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 5, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

khaliqgant commented Sep 5, 2026 •

edited by cubic-dev-ai Bot

Loading

chatgpt-codex-connector Bot commented Sep 5, 2026 •

edited

Loading

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading

github-actions Bot commented Sep 5, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading