Skip to content

feat(e2b): carry template home on runtime handles - #44

Merged
khaliqgant merged 3 commits into
mainfrom
agent/e2b-home-contract-0901
Sep 1, 2026
Merged

feat(e2b): carry template home on runtime handles#44
khaliqgant merged 3 commits into
mainfrom
agent/e2b-home-contract-0901

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Sep 1, 2026

Copy link
Copy Markdown
Member

Part of the exact E2B fleet path. Static gates and cross-repo review are recorded by Relayflow e2b-live-fleet-0901. Live dev proof follows merge and deployment; this PR does not claim production activation.


Summary by cubic

Carries the template's home directory onto E2B runtime handles so callers no longer need to pass a home dir per launch or lookup, and bumps @agent-relay/sandbox to 0.1.12.

  • Adds a defaultHomeDir runtime option that launch and lookup handles now inherit.
  • Blank per-call homeDir overrides fall back to the default instead of erasing it.
  • Creating a runtime with an explicitly blank defaultHomeDir throws an error.
  • Records the completed release trajectory for the 0.1.12 publish.

Written for commit 5061e48. Summary will update on new commits.

Review in cubic

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 1, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-01T08:23:13.818199Z 175a746 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 4 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: cb25617e-7d54-40d9-aec3-4d43b1251711

📥 Commits

Reviewing files that changed from the base of the PR and between 1455ce7 and 5061e48.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • .agentworkforce/trajectories/completed/2026-09/traj_h8qiliylqnav/summary.md
  • .agentworkforce/trajectories/completed/2026-09/traj_h8qiliylqnav/trajectory.json
  • src/e2b/runtime.test.ts

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 68a88f78-5027-4059-a6b0-e1d5d346b678

📥 Commits

Reviewing files that changed from the base of the PR and between 27b4249 and 1455ce7.

📒 Files selected for processing (3)
  • package.json
  • src/e2b/runtime.test.ts
  • src/e2b/runtime.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The E2B runtime adds a validated defaultHomeDir option. Blank home directory overrides now fall back to this default across launch, attach, and lookup paths. Tests cover validation and propagation. The package version changes to 0.1.12.

Changes

Default home directory

Layer / File(s) Summary
Runtime default contract
src/e2b/runtime.ts, src/e2b/runtime.test.ts
E2BSandboxRuntimeOptions supports defaultHomeDir. The runtime trims and validates the value. Tests cover blank configuration and helper support.
Home directory resolution and handle propagation
src/e2b/runtime.ts, src/e2b/runtime.test.ts, package.json
Launch, attach, and lookup paths resolve blank values to the runtime default. Tests verify handle propagation. The package version changes to 0.1.12.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: 🔵 Low · up to 1455c

This change centralizes the home directory used by launched, attached, and looked-up sandbox handles, but an attached or discovered sandbox could receive a default that does not match its actual environment and cause home-relative operations to use the wrong path. The PR is mergeable with explicit owner awareness or follow-up to validate the default for attached and looked-up sandboxes.

Poem

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the primary change: carrying the template home directory onto E2B runtime handles.
Description check ✅ Passed The description directly explains the defaultHomeDir option, fallback behavior, validation, and version update in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/e2b-home-contract-0901

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread package.json

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread src/e2b/runtime.test.ts Outdated
@khaliqgant
khaliqgant merged commit d68a71b into main Sep 1, 2026
4 checks passed
@khaliqgant
khaliqgant deleted the agent/e2b-home-contract-0901 branch September 1, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant