feat(e2b): carry template home on runtime handles - #44
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedNext included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe E2B runtime adds a validated ChangesDefault home directory
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to This change centralizes the home directory used by launched, attached, and looked-up sandbox handles, but an attached or discovered sandbox could receive a default that does not match its actual environment and cause home-relative operations to use the wrong path. The PR is mergeable with explicit owner awareness or follow-up to validate the default for attached and looked-up sandboxes. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Part of the exact E2B fleet path. Static gates and cross-repo review are recorded by Relayflow e2b-live-fleet-0901. Live dev proof follows merge and deployment; this PR does not claim production activation.
Summary by cubic
Carries the template's home directory onto E2B runtime handles so callers no longer need to pass a home dir per launch or lookup, and bumps
@agent-relay/sandboxto 0.1.12.defaultHomeDirruntime option that launch and lookup handles now inherit.homeDiroverrides fall back to the default instead of erasing it.defaultHomeDirthrows an error.Written for commit 5061e48. Summary will update on new commits.