Block truncated/lossy file regenerations from shipping - #10
Merged
Conversation
PR #9 committed a README that was the existing file echoed back and cut off mid-table — syntactically fine, so it passed validation and shipped. Root causes: .md files got no integrity check (static validation only syntax-checks TS/JS/JSON), the LLM client never inspected finish_reason so a max_tokens cut was returned silently, and the 4096-token cap is too small for full-file rewrites. - static.ts: validateChanges now takes the originals map and flags a modified file that is a truncated copy of the original (exact prefix, shorter) or has lost >50% of its content — covers .md and other non-code files that get no syntax check. This deterministically catches PR #9. - index.ts: pass repoContext.keyFiles as the originals to validateChanges. - client.ts: capture choice.finish_reason and warn when a response is cut off at max_tokens, so token-cap truncation is no longer silent. - base.ts: raise the Backend/Frontend output cap from 4096 to 8192 tokens. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #9 committed a README that was the existing file echoed back and cut off mid-table — syntactically fine, so it passed validation and shipped. Root causes: .md files got no integrity check (static validation only syntax-checks TS/JS/JSON), the LLM client never inspected finish_reason so a max_tokens cut was returned silently, and the 4096-token cap is too small for full-file rewrites.