Skip to content

Protect RecoContainer TRDtracklets access in absence of the TRD - #15670

Merged
shahor02 merged 2 commits into
AliceO2Group:devfrom
shahor02:pr_protTRD
Aug 10, 2026
Merged

Protect RecoContainer TRDtracklets access in absence of the TRD#15670
shahor02 merged 2 commits into
AliceO2Group:devfrom
shahor02:pr_protTRD

Conversation

@shahor02

@shahor02 shahor02 commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@miranov25

Copy link
Copy Markdown
Contributor

Hello Ruben,

I checked the bug and your proposed fix with the TimeAI review team.

The missing-TRD protection looks correct and should address the observed tpc-time-series crash. However, the reviewers found one unrelated issue in the current PR that appears to need correction before merge: RecoContainer::getTPCClustersMCLabels() is now conditioned on inputsTRD. TPC MC-label availability should not depend on whether TRD input is present.

Please see the attached review summary for the exact line and suggested correction.

I am patching the production release now. I am not sure whether we have suitable data without TRD at GSI, so I will check that and try to reproduce the missing-TRD configuration there as well.

Thanks,
Marian

GPT3_AI_PR15670_Official_Bug_Report_Review_20260810 (1).md

@shahor02

Copy link
Copy Markdown
Collaborator Author

@miranov25 thank for spotting, I've removed the stray protection.

@shahor02
shahor02 merged commit f16c6e4 into AliceO2Group:dev Aug 10, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants